Remove include_type_name from the relevant APIs.#35192
Merged
jtibshirani merged 1 commit intoelastic:masterfrom Nov 6, 2018
Merged
Remove include_type_name from the relevant APIs.#35192jtibshirani merged 1 commit intoelastic:masterfrom
jtibshirani merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-aggs |
f786bc5 to
c99cfd0
Compare
We've decided that the bulk, delete, get, index, update, and search APIs should not contain this request parameter, and we will instead accept both typed and typeless calls.
c99cfd0 to
540ba21
Compare
Contributor
Author
|
@elasticmachine test this please |
48 tasks
cbuescher
approved these changes
Nov 6, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
I only looked at a subset of the test changes, but the main code changes look good to me, at least wrt. to the goal of the PR that you mentioned in the descrption. Not sure if other follow-up discussion need to happen, but the change by itself is good I think.
Contributor
Author
|
Thanks @cbuescher for taking a look. We've agreed on this point, and are tracking the overall plan to types deprecation here: #35190 |
Contributor
Author
|
CC @elastic/es-clients |
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Nov 13, 2018
We've decided that the bulk, delete, get, index, update, and search APIs should not contain this request parameter, and we will instead accept both typed and typeless calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've decided that the bulk, delete, get, index, update, and search APIs should not contain this request parameter, and we will instead accept both typed and typeless calls.