HLRC: add support for the clear realm cache API#35163
Merged
jaymode merged 5 commits intoelastic:masterfrom Nov 6, 2018
Merged
HLRC: add support for the clear realm cache API#35163jaymode merged 5 commits intoelastic:masterfrom
jaymode merged 5 commits intoelastic:masterfrom
Conversation
This change adds support for clearing the cache of a realm. The realms cache may contain a stale set of credentials or incorrect role assignment, which can be corrected by clearing the cache of the entire realm or just that of a specific user. Relates elastic#29827
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
cc @elastic/es-security |
albertzaharovits
approved these changes
Nov 2, 2018
Contributor
albertzaharovits
left a comment
There was a problem hiding this comment.
LGTM 👍
If I were to add anything, I would more thoroughly test the ClearRealmCacheResponse, especially that nowAbstractStreamableXContentTestCase is a thing. But the response is simple enough for this to not be necessary.
Member
Author
|
run sample packaging tests |
jkakavas
approved these changes
Nov 5, 2018
| * | ||
| * @param request the request with the realm names and usernames to clear the cache for | ||
| * @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized | ||
| * @return the response from the enable user call |
jaymode
added a commit
that referenced
this pull request
Nov 6, 2018
This change adds support for clearing the cache of a realm. The realms cache may contain a stale set of credentials or incorrect role assignment, which can be corrected by clearing the cache of the entire realm or just that of a specific user. Relates #29827
98 tasks
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Nov 13, 2018
This change adds support for clearing the cache of a realm. The realms cache may contain a stale set of credentials or incorrect role assignment, which can be corrected by clearing the cache of the entire realm or just that of a specific user. Relates elastic#29827
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for clearing the cache of a realm. The realms
cache may contain a stale set of credentials or incorrect role
assignment, which can be corrected by clearing the cache of the entire
realm or just that of a specific user.
Relates #29827