[Docs] Add painless context details for bucket_selector#35162
Merged
polyfractal merged 4 commits intoelastic:masterfrom Nov 8, 2018
Merged
[Docs] Add painless context details for bucket_selector#35162polyfractal merged 4 commits intoelastic:masterfrom
polyfractal merged 4 commits intoelastic:masterfrom
Conversation
Adds docs for the bucket_selector context, an example and corresponding doc test
Collaborator
|
Pinging @elastic/es-core-infra |
17 tasks
jdconrad
reviewed
Nov 1, 2018
Contributor
jdconrad
left a comment
There was a problem hiding this comment.
@polyfractal Same as the bucket_script. Firstly, thank you! This looks good from the side to me. I would like @debadair or another writer to take a look for the docs side.
debadair
suggested changes
Nov 1, 2018
Contributor
debadair
left a comment
There was a problem hiding this comment.
Suggested some minor edits.
docs/painless/painless-contexts/painless-bucket-selector-agg-context.asciidoc
Show resolved
Hide resolved
docs/painless/painless-contexts/painless-bucket-selector-agg-context.asciidoc
Show resolved
Hide resolved
docs/painless/painless-contexts/painless-bucket-selector-agg-context.asciidoc
Show resolved
Hide resolved
docs/painless/painless-contexts/painless-bucket-selector-agg-context.asciidoc
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Tidied up, and also re-arranged sentence order in one place. :) |
debadair
approved these changes
Nov 2, 2018
Contributor
Author
|
Jenkins, test this please. |
polyfractal
pushed a commit
that referenced
this pull request
Nov 8, 2018
Adds docs for the bucket_selector context, an example and corresponding doc test
polyfractal
pushed a commit
that referenced
this pull request
Nov 8, 2018
Adds docs for the bucket_selector context, an example and corresponding doc test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds docs for
bucket_selectorcontext, including example and corresponding doc testSimilar to the
bucket_scriptPR, I opted to only test this through the doc testing mechanism since the script itself is trivial.Related to #34829