Skip to content

ingest: add common options to each processor's documentation#35091

Merged
jakelandis merged 3 commits intoelastic:masterfrom
jakelandis:doc_common_options
Nov 1, 2018
Merged

ingest: add common options to each processor's documentation#35091
jakelandis merged 3 commits intoelastic:masterfrom
jakelandis:doc_common_options

Conversation

@jakelandis
Copy link
Copy Markdown
Contributor

@jakelandis jakelandis commented Oct 30, 2018

  • adds if, on_failure, ignore_failure, and tag to table for each processor

part of #33188


Example rendered processor:
image

EDIT : update example

* adds `if`, `on_failure`, and `tag` to table for each processor

part of elastic#33188
@jakelandis jakelandis added >docs General docs changes :Distributed/Ingest Node Execution or management of Ingest Pipelines v7.0.0 v6.5.0 labels Oct 30, 2018
@jakelandis jakelandis requested a review from rjernst October 30, 2018 15:50
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra

@jakelandis
Copy link
Copy Markdown
Contributor Author

tagged as going back to only 6.5.0 since that is the first introduction of the if conditional and as of 6.5.0 Kibana console will also allow auto complete these 3 options. However, on_failure and tag (i believe) are valid back to the initial release.

@jakelandis
Copy link
Copy Markdown
Contributor Author

added ignore_failure to common options (missed in original commit)

Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// NOTCONSOLE



Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintentional extra newlines?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. thanks!

@jakelandis jakelandis merged commit 77fab62 into elastic:master Nov 1, 2018
jakelandis added a commit that referenced this pull request Nov 6, 2018
* adds `if`, `on_failure`, `tag`, and `ignore_failure` to table for each processor

part of #33188

* added ingore_failure

* fix whitespace noise
jakelandis added a commit that referenced this pull request Nov 6, 2018
* adds `if`, `on_failure`, `tag`, and `ignore_failure` to table for each processor

part of #33188

* added ingore_failure

* fix whitespace noise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Ingest Node Execution or management of Ingest Pipelines >docs General docs changes v6.5.0 v6.6.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants