Remove remaining line length violations in o.e.cluster#34941
Merged
rjernst merged 4 commits intoelastic:masterfrom Oct 30, 2018
Merged
Remove remaining line length violations in o.e.cluster#34941rjernst merged 4 commits intoelastic:masterfrom
rjernst merged 4 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
33 tasks
Member
|
There is a merge conflict in checkstyle_suppreasions.xml
…On Fri, Oct 26, 2018, 19:35 Elastic Machine ***@***.***> wrote:
Pinging @elastic/es-core-infra
<https://github.com/orgs/elastic/teams/es-core-infra>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#34941 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLoq2G2poBItMZMVJyjxuCc3VVP4Ikks5uo5w4gaJpZM4X9HZ_>
.
|
nik9000
approved these changes
Oct 27, 2018
Member
nik9000
left a comment
There was a problem hiding this comment.
I left a few minor alignment things, otherwise LGTM.
| " {\"allocate_empty_primary\" : {\"index\" : \"test\", \"shard\" : 1," + | ||
| " \"node\" : \"node1\", \"accept_data_loss\" : true}}\n" + | ||
| " ,{\"allocate_stale_primary\" : {\"index\" : \"test\", \"shard\" : 2," + | ||
| " \"node\" : \"node1\", \"accept_data_loss\" : true}}\n" + |
Member
There was a problem hiding this comment.
Could you line up the opening quotes here?
| clusterState = ClusterState.builder(clusterState).nodes(DiscoveryNodes.builder(clusterState.nodes()) | ||
| .add(newNode("node3")).add(newNode("node4")).add(newNode("node5")).add(newNode("node6")).add(newNode("node7")).add(newNode("node8")).add(newNode("node9")).add(newNode("node10"))) | ||
| .add(newNode("node3")).add(newNode("node4")).add(newNode("node5")).add(newNode("node6")) | ||
| .add(newNode("node7")).add(newNode("node8")).add(newNode("node9")).add(newNode("node10"))) |
Member
There was a problem hiding this comment.
Could you line this up with the one above it?
| client().admin().indices().prepareCreate("test").setSettings(Settings.builder() | ||
| .put("index.number_of_shards", "1").put("index.number_of_replicas", 0).put("index.routing.allocation.include.tag", "A")).execute().actionGet(); | ||
| .put("index.number_of_shards", "1").put("index.number_of_replicas", 0) | ||
| .put("index.routing.allocation.include.tag", "A")).execute().actionGet(); |
Member
There was a problem hiding this comment.
Could you line this up with the one above it?
| client().admin().indices().prepareCreate("test").setSettings(Settings.builder() | ||
| .put("index.number_of_shards", "4").put("index.number_of_replicas", 0).put("index.routing.allocation.include.tag", "A")).execute().actionGet(); | ||
| .put("index.number_of_shards", "4").put("index.number_of_replicas", 0) | ||
| .put("index.routing.allocation.include.tag", "A")).execute().actionGet(); |
rjernst
added a commit
that referenced
this pull request
Oct 30, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates #34923, #34884