[Style] Remove line length violations from ingest actions#34886
Merged
jdconrad merged 2 commits intoelastic:masterfrom Oct 26, 2018
Merged
[Style] Remove line length violations from ingest actions#34886jdconrad merged 2 commits intoelastic:masterfrom
jdconrad merged 2 commits intoelastic:masterfrom
Conversation
33 tasks
hub-cap
approved these changes
Oct 25, 2018
Contributor
Author
Collaborator
|
Pinging @elastic/es-core-infra |
nik9000
approved these changes
Oct 25, 2018
Member
nik9000
left a comment
There was a problem hiding this comment.
LGTM. I left one thing I'd love for you to change but thanks for cleaning these up!
|
|
||
| public class GetPipelineRequestBuilder extends MasterNodeReadOperationRequestBuilder<GetPipelineRequest, GetPipelineResponse, GetPipelineRequestBuilder> { | ||
| public class GetPipelineRequestBuilder | ||
| extends MasterNodeReadOperationRequestBuilder<GetPipelineRequest, GetPipelineResponse, GetPipelineRequestBuilder> { |
Member
There was a problem hiding this comment.
Could you indent this one more time so the class declaration doesn't line up with the class body?
Contributor
Author
There was a problem hiding this comment.
Good catch. Fixed.
Member
There was a problem hiding this comment.
It is my pet complaint to IntelliJ users 😄
Contributor
Author
There was a problem hiding this comment.
@nik9000 I hear you! I just redid my system and forgot to disable Intellij loading the editorconfig file that is checked in. I wonder if other Intellij users aren't doing the same.
jdconrad
added a commit
that referenced
this pull request
Oct 26, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all line length violations from ingest actions to get rid the need for checkstyle suppression in this package.
Parent issue: #34884