[ML-Dataframe] add validation and mapping detection#34844
Merged
hendrikmuhs merged 6 commits intoelastic:feature/fibfrom Nov 15, 2018
Merged
[ML-Dataframe] add validation and mapping detection#34844hendrikmuhs merged 6 commits intoelastic:feature/fibfrom
hendrikmuhs merged 6 commits intoelastic:feature/fibfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core |
hendrikmuhs
commented
Nov 5, 2018
...ilder/src/main/java/org/elasticsearch/xpack/ml/featureindexbuilder/support/JobValidator.java
Outdated
Show resolved
Hide resolved
269eb1d to
e4aa7bf
Compare
benwtrent
reviewed
Nov 13, 2018
...ilder/src/main/java/org/elasticsearch/xpack/ml/featureindexbuilder/support/Aggregations.java
Outdated
Show resolved
Hide resolved
...ilder/src/main/java/org/elasticsearch/xpack/ml/featureindexbuilder/support/JobValidator.java
Outdated
Show resolved
Hide resolved
...ilder/src/main/java/org/elasticsearch/xpack/ml/featureindexbuilder/support/JobValidator.java
Outdated
Show resolved
Hide resolved
...ilder/src/main/java/org/elasticsearch/xpack/ml/featureindexbuilder/support/JobValidator.java
Outdated
Show resolved
Hide resolved
067e07d to
846d5be
Compare
Author
|
The remaining CI issue is the known problem that this new plugin usage report is not integrated in the doc IT. |
benwtrent
approved these changes
Nov 14, 2018
Author
|
Thanks for the review @benwtrent ! |
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jan 2, 2019
Remove the line suppression for this package and fix offedning lines relates elastic#34844
pgomulka
added a commit
that referenced
this pull request
Jan 2, 2019
Remove the line suppression for this package and fix offedning lines relates #34844
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jan 10, 2019
Remove the line suppression for this package and fix offedning lines BackPort elastic#37071 relates elastic#34844
pgomulka
added a commit
that referenced
this pull request
Jan 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Branch PR
add job validation and deduction of field mappings for the target index