Skip to content

Test: Fix last reference to SearchScript#34731

Merged
rjernst merged 4 commits intoelastic:masterfrom
rjernst:fix_domain_split
Oct 24, 2018
Merged

Test: Fix last reference to SearchScript#34731
rjernst merged 4 commits intoelastic:masterfrom
rjernst:fix_domain_split

Conversation

@rjernst
Copy link
Copy Markdown
Member

@rjernst rjernst commented Oct 23, 2018

This was accidentally left over when converting to FieldScript.

closes #34683

This was accidentally left over when converting to FieldScript.

closes elastic#34683
@rjernst rjernst added >bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v7.0.0 v6.5.0 labels Oct 23, 2018
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra

@rjernst
Copy link
Copy Markdown
Member Author

rjernst commented Oct 23, 2018

@elasticmachine test this please

Copy link
Copy Markdown
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the empty test testEmptyToLetBuildPass that was added too?

@rjernst
Copy link
Copy Markdown
Member Author

rjernst commented Oct 23, 2018

Weird, I swear I did that before. Done now!

Copy link
Copy Markdown
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rjernst rjernst merged commit 596b5cf into elastic:master Oct 24, 2018
@rjernst rjernst deleted the fix_domain_split branch October 24, 2018 00:26
kcm pushed a commit that referenced this pull request Oct 30, 2018
This was accidentally left over when converting to FieldScript.

closes #34683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v6.5.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PainlessDomainSplitIT#testIsolated fails reliably with compilation error

4 participants