convert EmptyDirTask.groovy to .java by vboulaye · Pull Request #34672 · elastic/elasticsearch

vboulaye · 2018-10-20T20:26:01Z

related to #34459, convert the EmptyDirTask.groovy to java
I tried to follow the instructions in the issue notes and the related FileContentsTask PR, but I am still new to this...

elasticmachine · 2018-10-21T20:01:26Z

Pinging @elastic/es-core-infra

buildSrc/src/test/java/org/elasticsearch/gradle/EmptyDirTaskTest.java

jasontedor · 2018-10-21T20:05:45Z

@elasticmachine test this please

alpar-t · 2018-10-22T06:10:01Z

@vboulaye looks like CI picked up on some inconsistent naming.
You can pick these up without waiting for CI with: ./gradlew precommit --parallel.

23:15:48 Not all subclasses of GradleUnitTestCase match the naming convention. Concrete classes must end with [Tests]:
23:15:48  * org.elasticsearch.gradle.EmptyDirTaskTest

alpar-t · 2018-10-22T13:06:23Z

@elasticmachine test this please

alpar-t

Thanks for your contribution @vboulaye I left a few small comments.

buildSrc/src/main/java/org/elasticsearch/gradle/EmptyDirTask.java

buildSrc/src/test/java/org/elasticsearch/gradle/EmptyDirTaskTests.java

alpar-t · 2018-10-23T08:39:41Z

@elasticmachine test this please

alpar-t · 2018-10-24T13:54:02Z

@elasticmachine test this please

…k-to-java

alpar-t · 2018-11-16T13:50:35Z

@elasticmachine test this please

danielmitterdorfer · 2019-01-29T06:52:56Z

@elasticmachine test this please

…k-to-java

danielmitterdorfer · 2019-01-29T07:22:45Z

I have merged the latest master into the fork as the PR CI build has failed due to the outdated branch.

danielmitterdorfer · 2019-01-29T07:22:49Z

@elasticmachine test this please

danielmitterdorfer · 2019-01-29T08:49:57Z

@elasticmachine run elasticsearch-ci/default-distro

danielmitterdorfer · 2019-01-29T09:30:33Z

@elasticmachine run elasticsearch-ci/default-distro

alpar-t · 2019-01-30T12:15:10Z

@elasticmachine test this please

…k-to-java

…asticsearch into convert-emptydirtask-to-java

alpar-t · 2019-03-19T06:23:10Z

@elasticmachine test this please

alpar-t · 2019-03-19T06:49:53Z

@vboulaye can you look at these test failures please

08:37:08 
08:37:08 Suite: org.elasticsearch.gradle.EmptyDirTaskTests
08:37:08 ERROR   0.04s J3 | EmptyDirTaskTests.testCreateEmptyDirNoPermissions <<< FAILURES!
08:37:08    > Throwable #1: java.io.IOException: No such file or directory
08:37:08    > 	at __randomizedtesting.SeedInfo.seed([6F817AD5CAEDB71F:F41C0C60338EE88]:0)
08:37:08    > 	at java.base/java.io.UnixFileSystem.createFileExclusively(Native Method)
08:37:08    > 	at java.base/java.io.File.createTempFile(File.java:2090)
08:37:08 ERROR   0.02s J3 | EmptyDirTaskTests.testCreateEmptyDir <<< FAILURES!
08:37:08    > Throwable #1: java.io.IOException: No such file or directory
08:37:08    > 	at __randomizedtesting.SeedInfo.seed([6F817AD5CAEDB71F:A6092EB73A3AD97F]:0)
08:37:08    > 	at java.base/java.io.UnixFileSystem.createFileExclusively(Native Method)
08:37:08    > 	at java.base/java.io.File.createTempFile(File.java:2090)
08:37:08 Completed [2/8] on J3 in 0.12s, 2 tests, 2 errors <<< FAILURES!

vboulaye · 2019-03-20T13:29:10Z

Hi, I'll have a look at what is broken now.

vboulaye · 2019-03-20T18:44:59Z

I tried to reproduce the error but I do not see how to do that:
The failure was apparently thrown by the RandomizedTestingTask which somehow prevented the TemporaryFolder @rule to create the temp directory build in the setup for the tests.

I tried to reproduce the issue by setting the same seed on the command line:

./gradlew :build-tools:unitTest -Dtests.seed="6F817AD5CAEDB71F:A6092EB73A3AD97F" -Dtests.class=org.elasticsearch.gradle.EmptyDirTaskTests

But the tests are passing.

I also tried adding @Seed with the 2 seeds on the class/method level. But the test are passing too.

There is another test using TemporaryFolder;; BuildExamplePluginsIT

How can I reproduce the issue ?
Or how should I proceed to build a temp directory for my tests ?

alpar-t · 2019-03-21T07:04:41Z

@vboulaye thanks for looking at the failure. I have seen an incompatibility between randomized testing and rules to create temp folders before, but didn't pursue it at the time,
because the rule is not necessary in most cases in these tests, that's also the case with your test, no need to pass that in the gradle test project tooling takes care of that for you, just don't pass a directory.

vboulaye · 2019-03-21T09:02:19Z

Hi,
I removed the use of TemporaryFolder by reusing the project build directory to create my test folder manually.
Will this work ?

vboulaye · 2019-03-21T09:37:16Z

My gradle check failed again...

Suite: org.elasticsearch.gradle.EmptyDirTaskTests
ERROR   0.01s J3 | EmptyDirTaskTests.testCreateEmptyDirNoPermissions <<< FAILURES!
   > Throwable #1: java.io.IOException: No such file or directory
   >    at __randomizedtesting.SeedInfo.seed([A83400AACDDF4B1E:C8F4BAB9040A1289]:0)
   >    at java.base/java.io.UnixFileSystem.createFileExclusively(Native Method)
   >    at java.base/java.io.File.createTempFile(File.java:2090)
   >    at org.elasticsearch.gradle.EmptyDirTaskTests.getNewNonExistingTempFolderFile(EmptyDirTaskTests.java:73)
   >    at org.elasticsearch.gradle.EmptyDirTaskTests.testCreateEmptyDirNoPermissions(EmptyDirTaskTests.java:57)
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   >    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   >    at java.base/java.lang.reflect.Method.invoke(Method.java:566)
ERROR   0.01s J3 | EmptyDirTaskTests.testCreateEmptyDir <<< FAILURES!
   > Throwable #1: java.io.IOException: No such file or directory
   >    at __randomizedtesting.SeedInfo.seed([A83400AACDDF4B1E:61BC54C83D08257E]:0)
   >    at java.base/java.io.UnixFileSystem.createFileExclusively(Native Method)
   >    at java.base/java.io.File.createTempFile(File.java:2090)
   >    at org.elasticsearch.gradle.EmptyDirTaskTests.getNewNonExistingTempFolderFile(EmptyDirTaskTests.java:73)
   >    at org.elasticsearch.gradle.EmptyDirTaskTests.testCreateEmptyDir(EmptyDirTaskTests.java:36)
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   >    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   >    at java.base/java.lang.reflect.Method.invoke(Method.java:566)

I'll have to look at it again.

alpar-t · 2019-03-21T14:00:08Z

buildSrc/src/test/java/org/elasticsearch/gradle/EmptyDirTaskTests.java

+        return newEmptyFolder;
+    }
+
+    private Project createProject() throws IOException {


can you please inline this and the next method as they are now just one-liners.

alpar-t · 2019-03-21T14:00:25Z

@elasticmachine test this please

alpar-t · 2019-03-22T09:22:36Z

@elasticmachine test this please

alpar-t · 2019-03-25T08:04:16Z

@elaticmachine run elasticsearch-ci/packaging-sample , run elasticsearch-ci/default-distro and run elasticsearch-ci/bwc

…k-to-java

…asticsearch into convert-emptydirtask-to-java

alpar-t · 2019-03-25T12:45:02Z

@elasticmachine test this please

alpar-t · 2019-06-12T12:26:45Z

@elasticmachine update branch

alpar-t · 2019-06-12T12:42:52Z

@elasticmachine update branch

…k-to-java

alpar-t · 2019-06-12T12:55:17Z

@elasticmachine test this please

convert EmptyDirTask.groovy to .java

6a5afa3

jasontedor requested review from alpar-t and rjernst October 21, 2018 20:00

jasontedor added the :Delivery/Build Build or test infrastructure label Oct 21, 2018

jasontedor reviewed Oct 21, 2018

View reviewed changes

buildSrc/src/test/java/org/elasticsearch/gradle/EmptyDirTaskTest.java Outdated Show resolved Hide resolved

append missing end newline

35c5272

alpar-t mentioned this pull request Oct 22, 2018

Replace groovy build-tools (buildSrc) with java #34459

Open

31 tasks

rename test

a349d9c

alpar-t reviewed Oct 22, 2018

View reviewed changes

various fixes

7e62568

Merge remote-tracking branch 'origin/master' into convert-emptydirtas…

f5b5f7b

…k-to-java

Merge remote-tracking branch 'origin/master' into convert-emptydirtas…

28648dc

…k-to-java

michaelbaamonde added the team-discuss label Feb 28, 2019

danielmitterdorfer removed the team-discuss label Mar 6, 2019

alpar-t added 2 commits March 7, 2019 15:54

Merge remote-tracking branch 'origin/master' into convert-emptydirtas…

43a376d

…k-to-java

Merge branch 'convert-emptydirtask-to-java' of github.com:vboulaye/el…

8108314

…asticsearch into convert-emptydirtask-to-java

vboulaye added 2 commits March 21, 2019 09:59

Remove dependency on TemporaryFolder

e306c3c

Remove dependency on TemporaryFolder

d7b2d6d

Remove dependency on TemporaryFolder - do not create the file in setup

b53ab3a

alpar-t reviewed Mar 21, 2019

View reviewed changes

inline oneliners

1423939

alpar-t added 2 commits March 25, 2019 14:39

Merge remote-tracking branch 'origin/master' into convert-emptydirtas…

571a0b7

…k-to-java

Merge branch 'convert-emptydirtask-to-java' of github.com:vboulaye/el…

260bcd5

…asticsearch into convert-emptydirtask-to-java

Merge remote-tracking branch 'origin/master' into convert-emptydirtas…

5d09abb

…k-to-java

alpar-t merged commit de32917 into elastic:master Jun 13, 2019

alpar-t pushed a commit that referenced this pull request Jun 13, 2019

convert EmptyDirTask.groovy to .java (#34672)

209a493

pcsanwald added the v8.0.0 label Jun 14, 2019

alpar-t added the v7.3.0 label Jun 17, 2019

mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

Conversation

vboulaye commented Oct 20, 2018

Uh oh!

elasticmachine commented Oct 21, 2018

Uh oh!

Uh oh!

jasontedor commented Oct 21, 2018

Uh oh!

alpar-t commented Oct 22, 2018

Uh oh!

alpar-t commented Oct 22, 2018

Uh oh!

alpar-t left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alpar-t commented Oct 23, 2018

Uh oh!

alpar-t commented Oct 24, 2018

Uh oh!

alpar-t commented Nov 16, 2018

Uh oh!

danielmitterdorfer commented Jan 29, 2019

Uh oh!

danielmitterdorfer commented Jan 29, 2019

Uh oh!

danielmitterdorfer commented Jan 29, 2019

Uh oh!

danielmitterdorfer commented Jan 29, 2019

Uh oh!

danielmitterdorfer commented Jan 29, 2019

Uh oh!

alpar-t commented Jan 30, 2019

Uh oh!

alpar-t commented Mar 19, 2019

Uh oh!

alpar-t commented Mar 19, 2019

Uh oh!

vboulaye commented Mar 20, 2019

Uh oh!

vboulaye commented Mar 20, 2019

Uh oh!

alpar-t commented Mar 21, 2019

Uh oh!

vboulaye commented Mar 21, 2019

Uh oh!

vboulaye commented Mar 21, 2019

Uh oh!

alpar-t Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

alpar-t commented Mar 21, 2019

Uh oh!

alpar-t commented Mar 22, 2019

Uh oh!

alpar-t commented Mar 25, 2019

Uh oh!

alpar-t commented Mar 25, 2019

Uh oh!

alpar-t commented Jun 12, 2019

Uh oh!

alpar-t commented Jun 12, 2019

Uh oh!

alpar-t commented Jun 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants