Merged
Conversation
Collaborator
|
Pinging @elastic/es-security |
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@elasticmachine retest this please |
hub-cap
suggested changes
Oct 19, 2018
Contributor
hub-cap
left a comment
There was a problem hiding this comment.
Mostly nits and missing one test. Easy peasy!
| } | ||
|
|
||
| @Override | ||
| public XContentBuilder toXContent(XContentBuilder builder, Params params) { |
Contributor
There was a problem hiding this comment.
this is not needed, an the class does not have to be a ToXContentObject either.
| @@ -0,0 +1,46 @@ | |||
| [[java-rest-high-security-delete-role]] | |||
Contributor
There was a problem hiding this comment.
There is a nicer way to do the docs now. See #34203
| /** | ||
| * Response for a role being deleted from the native realm | ||
| */ | ||
| public final class DeleteRoleResponse { |
Contributor
There was a problem hiding this comment.
We have some better tests to test the responses now too. Check out https://github.com/elastic/elasticsearch/blob/master/client/rest-high-level/src/test/java/org/elasticsearch/client/watcher/ActivateWatchResponseTests.java
hub-cap
approved these changes
Oct 19, 2018
ywelsch
added a commit
that referenced
this pull request
Oct 20, 2018
Adds the "Delete role" API to the high-level REST client.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Adds the "Delete role" API to the high-level REST client.
98 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the "Delete role" API to the high-level REST client.