Docs: Reenable rollup docs tests#34564
Merged
nik9000 merged 5 commits intoelastic:masterfrom Oct 18, 2018
Merged
Conversation
We'd disabled them because we didn't have a way to clean up after each test. I implemented elastic#34342 which adds the clean ups so now we can re-enable the tests. In the `setup` sections we have to use `raw` requests instead of `x-pack` requests because we don't have the json config for x-pack. Closes elastic#33319
Collaborator
|
Pinging @elastic/es-search-aggs |
Member
Author
|
Merged! Thanks for reviewing @polyfractal! I'll wait for a clean 6.x intake build before doing the backport. |
nik9000
added a commit
that referenced
this pull request
Oct 19, 2018
We'd disabled them because we didn't have a way to clean up after each test. I implemented #34342 which adds the clean ups so now we can re-enable the tests. In the `setup` sections we have to use `raw` requests instead of `x-pack` requests because we don't have the json config for x-pack. Closes #33319
Member
Author
|
Backs finally done! |
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
We'd disabled them because we didn't have a way to clean up after each test. I implemented #34342 which adds the clean ups so now we can re-enable the tests. In the `setup` sections we have to use `raw` requests instead of `x-pack` requests because we don't have the json config for x-pack. Closes #33319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd disabled them because we didn't have a way to clean up after each
test. I implemented #34342 which adds the clean ups so now we can
re-enable the tests.
In the
setupsections we have to userawrequests instead ofx-packrequests because we don't have the json config for x-pack.Closes #33319