MINOR: Remove Deadcode in aggregtions.support#34323
Merged
original-brownbear merged 3 commits intoelastic:masterfrom Oct 26, 2018
original-brownbear:remove-deadcode-aggregation-support
Merged
MINOR: Remove Deadcode in aggregtions.support#34323original-brownbear merged 3 commits intoelastic:masterfrom original-brownbear:remove-deadcode-aggregation-support
original-brownbear merged 3 commits intoelastic:masterfrom
original-brownbear:remove-deadcode-aggregation-support
Conversation
* Removed methods are just unused (the exceptions being isGeoPoint() and is isFloatingPoint() but those could more efficiently be replaced by enum comparisons to simplify the code) * Remove exceptions aren't thrown
Collaborator
|
Pinging @elastic/es-search-aggs |
…gregation-support
…gregation-support
Contributor
Author
|
@cbuescher thanks! |
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
* Removed methods are just unused (the exceptions being isGeoPoint() and is isFloatingPoint() but those could more efficiently be replaced by enum comparisons to simplify the code) * Remove exceptions aren't thrown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isFloatingPoint() but those could more efficiently be replaced by enum comparisons to streamline the code for the type checks)