Preserve the order of nested documents in the Lucene index#34225
Merged
jimczi merged 1 commit intoelastic:masterfrom Oct 3, 2018
Merged
Preserve the order of nested documents in the Lucene index#34225jimczi merged 1 commit intoelastic:masterfrom
jimczi merged 1 commit intoelastic:masterfrom
Conversation
Today we reverse the initial order of the nested documents when we index them in order to ensure that parents documents appear after their children. This means that a query will always match nested documents in the reverse order of their offsets in the source document. Reversing all documents is not needed so this change ensures that parents documents appear after their children without modifying the initial order in each nested level. This allows to match children in the order of their appearance in the source document which is a requirement to efficiently implement elastic#33587. Old indices created before this change will continue to reverse the order of nested documents to ensure backwark compatibility.
Collaborator
|
Pinging @elastic/es-search-aggs |
martijnvg
approved these changes
Oct 3, 2018
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM - Leaving the children in the original provided order makes a lot of sense!
jimczi
added a commit
that referenced
this pull request
Oct 3, 2018
Today we reverse the initial order of the nested documents when we index them in order to ensure that parents documents appear after their children. This means that a query will always match nested documents in the reverse order of their offsets in the source document. Reversing all documents is not needed so this change ensures that parents documents appear after their children without modifying the initial order in each nested level. This allows to match children in the order of their appearance in the source document which is a requirement to efficiently implement #33587. Old indices created before this change will continue to reverse the order of nested documents to ensure backwark compatibility.
jimczi
added a commit
that referenced
this pull request
Oct 3, 2018
jimczi
added a commit
that referenced
this pull request
Oct 3, 2018
jimczi
added a commit
that referenced
this pull request
Oct 4, 2018
erayarslan
added a commit
to erayarslan/elasticsearch
that referenced
this pull request
Oct 4, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Today we reverse the initial order of the nested documents when we index them in order to ensure that parents documents appear after their children. This means that a query will always match nested documents in the reverse order of their offsets in the source document. Reversing all documents is not needed so this change ensures that parents documents appear after their children without modifying the initial order in each nested level. This allows to match children in the order of their appearance in the source document which is a requirement to efficiently implement #33587. Old indices created before this change will continue to reverse the order of nested documents to ensure backwark compatibility.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we reverse the initial order of the nested documents when we
index them in order to ensure that parents documents appear after
their children. This means that a query will always match nested documents
in the reverse order of their offsets in the source document.
Reversing all documents is not needed so this change ensures that parents
documents appear after their children without modifying the initial order
in each nested level. This allows to match children in the order of their
appearance in the source document which is a requirement to efficiently
implement #33587. Old indices created before this change will continue
to reverse the order of nested documents to ensure backwark compatibility.