HLRC: Add ILM Retry#33990
HLRC: Add ILM Retry#33990original-brownbear merged 15 commits intoelastic:index-lifecyclefrom original-brownbear:hlrc-ilm-retry-step
Conversation
* Relates #33100
|
Pinging @elastic/es-core-infra |
hub-cap
left a comment
There was a problem hiding this comment.
I dont see any docs or request converter tests. I understand that you wouldn't need to do response tests since there is no response. Other than that, it looks good.
| return request; | ||
| } | ||
|
|
||
| static Request retryLifecycle(RetryLifecyclePolicyRequest retryLifecyclePolicyRequest) { |
There was a problem hiding this comment.
These should be in some IndexLifecycleRequestConverters class. i dont think it exists yet.
There was a problem hiding this comment.
Yeah, ILM stuff hasn't been moved to a separate RequestConverters class yet. I'd say this is okay for this PR since we'll do a mass move at some point before merging anyway.
| return this; | ||
| } | ||
|
|
||
| EndpointBuilder addCommaSeparatedPathParts(List<String> parts) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
I just added this to save a toArray() call here, seemed cleaner to just add that API, but I don't have a strong opinion here :)
|
@hub-cap added request converter test :) |
|
@original-brownbear have a look at the other PRs. They add a asciidoc page as well as a DocumentationIT test to back the asciidoc for the API. |
|
@hub-cap got it thanks, will add docs shortly :) |
|
as long as yall do it, im fine not blocking this. |
|
thanks @original-brownbear, we're looking into it |
|
@talevy seems you guys fixed it thanks green now after merging in |
* HLRC: Add ILM Retry * Relates #33100
Uh oh!
There was an error while loading. Please reload this page.