HLRC: ML start data feed API#33898
Merged
benwtrent merged 3 commits intoelastic:masterfrom Sep 21, 2018
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
Collaborator
|
Pinging @elastic/ml-core |
droberts195
reviewed
Sep 20, 2018
droberts195
left a comment
There was a problem hiding this comment.
I just left a suggestion for the docs.
| -------------------------------------------------- | ||
| include-tagged::{doc-tests}/MlClientDocumentationIT.java[x-pack-ml-start-datafeed-request-options] | ||
| -------------------------------------------------- | ||
| <1> Set when the datafeed should end |
There was a problem hiding this comment.
I think we should document the format and special values here as well as in the Javadoc as this is so important for correct usage of the endpoint. For "end":
- If it's not set then the datafeed will run continuously
nowis a special value- Otherwise it can be an ISO8601 time format or seconds or milliseconds since the epoch
| include-tagged::{doc-tests}/MlClientDocumentationIT.java[x-pack-ml-start-datafeed-request-options] | ||
| -------------------------------------------------- | ||
| <1> Set when the datafeed should end | ||
| <2> Set when the datafeed should start |
There was a problem hiding this comment.
I think we should document the format and special values here as well as in the Javadoc as this is so important for correct usage of the endpoint. For "start":
- If it's not set then the datafeed will start from the earliest data in the input indices
- Otherwise it can be an ISO8601 time format or seconds or milliseconds since the epoch
benwtrent
added a commit
that referenced
this pull request
Sep 21, 2018
* HLRC: ML start data feed API
98 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ML Start data feed API call to the HLRC
Relates to #29827