HLRC: Reindex should support requests_per_seconds parameter#33808
Merged
cbuescher merged 3 commits intoelastic:masterfrom Sep 20, 2018
Merged
HLRC: Reindex should support requests_per_seconds parameter#33808cbuescher merged 3 commits intoelastic:masterfrom
requests_per_seconds parameter#33808cbuescher merged 3 commits intoelastic:masterfrom
Conversation
The high level Rest clients reindex method currently doesn't pass on the "requests_per_second" that are optionally set in ReindexRequest through the Rest layer. This change makes sure the value is added to the request parameters if set.
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
@nik9000 would you mind taking a look at this? I will need something like this for the other incoming HL client work on rethrotteling I'm doing, but I factored this out as an indipendent change. |
Member
Author
|
I made the additions in RequestConverters to support |
cbuescher
pushed a commit
that referenced
this pull request
Sep 20, 2018
The high level Rest clients reindex method currently doesn't pass on the "requests_per_second" that are optionally set in ReindexRequest through the Rest layer. This change makes sure the value is added to the request parameters if set and also includes it for the update-by-query and delete-by-query cases.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
The high level Rest clients reindex method currently doesn't pass on the "requests_per_second" that are optionally set in ReindexRequest through the Rest layer. This change makes sure the value is added to the request parameters if set and also includes it for the update-by-query and delete-by-query cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The high level Rest clients reindex method currently doesn't pass on the
"requests_per_second" that are optionally set in ReindexRequest through the Rest
layer. This change makes sure the value is added to the request parameters if
set.