Rename "after" to "minimum_age" in lifecycle definition#33530
Merged
dakrone merged 2 commits intoelastic:index-lifecyclefrom Sep 9, 2018
Merged
Rename "after" to "minimum_age" in lifecycle definition#33530dakrone merged 2 commits intoelastic:index-lifecyclefrom
dakrone merged 2 commits intoelastic:index-lifecyclefrom
Conversation
This renames the "after" field to better reflect what the meaning is. Supercedes elastic#32624
Collaborator
|
Pinging @elastic/es-core-infra |
AthenaEryma
suggested changes
Sep 7, 2018
Contributor
There was a problem hiding this comment.
Please also make these changes to the client version of the Phase class.
Member
Author
|
Whoops forgot about the HLRC stuff since it's in a different package, thanks Gordon |
Member
Author
|
Thanks @gwbrown, I pushed a commit that changed it in the HLRC also |
AthenaEryma
approved these changes
Sep 7, 2018
dakrone
added a commit
that referenced
this pull request
Sep 9, 2018
This renames the "after" field to better reflect what the meaning is. Supercedes #32624
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the "after" field to better reflect what the meaning is.
Supercedes #32624