Pass TranslogRecoveryRunner to engine from outside#33449
Merged
dnhatn merged 1 commit intoelastic:masterfrom Sep 6, 2018
Merged
Pass TranslogRecoveryRunner to engine from outside#33449dnhatn merged 1 commit intoelastic:masterfrom
dnhatn merged 1 commit intoelastic:masterfrom
Conversation
This commit allows us to use different TranslogRecoveryRunner when recovering an engine from its local translog. This change is a prerequisite for the commit-based rollback PR (elastic#32867). See elastic#32867 (comment)
Collaborator
|
Pinging @elastic/es-distributed |
bleskes
approved these changes
Sep 6, 2018
Contributor
bleskes
left a comment
There was a problem hiding this comment.
LGTM. I'm curious to see what the other usage will be :)
Member
Author
dnhatn
added a commit
that referenced
this pull request
Sep 6, 2018
This commit allows us to use different TranslogRecoveryRunner when recovering an engine from its local translog. This change is a prerequisite for the commit-based rollback PR. Relates #32867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows us to use different TranslogRecoveryRunner when recovering an engine from its local translog. This change is a prerequisite for the commit-based rollback PR (#32867).
Relates: #32867 (comment)