Add script_filter tokenfilter#33431
Merged
romseygeek merged 6 commits intoelastic:masterfrom Sep 11, 2018
romseygeek:scripted-stop-filter
Merged
Add script_filter tokenfilter#33431romseygeek merged 6 commits intoelastic:masterfrom romseygeek:scripted-stop-filter
romseygeek merged 6 commits intoelastic:masterfrom
romseygeek:scripted-stop-filter
Conversation
Collaborator
|
Pinging @elastic/es-search-aggs |
nik9000
approved these changes
Sep 6, 2018
|
|
||
| public boolean isKeyword() { | ||
| return isKeyword; | ||
| return keywordAtt.isKeyword(); |
rjernst
reviewed
Sep 6, 2018
Member
rjernst
left a comment
There was a problem hiding this comment.
Can we use consistent terminology in the class names and token filter name? I think we should use "predicate" terminology everywhere? This will leave the namespace open for other types of scripted token filters in the future.
| -------------------------------------------------- | ||
| // CONSOLE | ||
|
|
||
| <1> This will skip tokens that are 5 characters long or less |
Member
There was a problem hiding this comment.
This description would make more sense with positive logic, since the predicate is positive based. So something like:
<1> This will emit tokens that are more than 5 characters long
Contributor
Author
|
@rjernst so call it |
Member
|
How about |
rjernst
approved these changes
Sep 8, 2018
Member
rjernst
left a comment
There was a problem hiding this comment.
Thanks @romseygeek. The new naming LGTM.
| [[analysis-scriptfilter-tokenfilter]] | ||
| === Scripted Filtering Token Filter | ||
| [[analysis-predicatefilter-tokenfilter]] | ||
| === Predicate Token Script Filter |
Member
There was a problem hiding this comment.
Token Script Filter -> Token Filter Script
romseygeek
added a commit
that referenced
this pull request
Sep 11, 2018
This allows users to filter out tokens from a TokenStream using painless scripts, instead of having to write specialised Java code and packaging it up into a plugin. The commit also refactors the AnalysisPredicateScript.Token class so that it wraps and makes read-only an AttributeSource.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 11, 2018
* master: Preserve cluster settings on full restart tests (elastic#33590) Use IndexWriter.getFlushingBytes() rather than tracking it ourselves (elastic#33582) Fix upgrading of list settings (elastic#33589) Add read-only Engine (elastic#33563) HLRC: Add ML get categories API (elastic#33465) SQL: Adds MONTHNAME, DAYNAME and QUARTER functions (elastic#33411) Add predicate_token_filter (elastic#33431) Fix Replace function. Adds more tests to all string functions. (elastic#33478) [ML] Rename input_fields to column_names in file structure (elastic#33568)
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 11, 2018
* master: (91 commits) Preserve cluster settings on full restart tests (elastic#33590) Use IndexWriter.getFlushingBytes() rather than tracking it ourselves (elastic#33582) Fix upgrading of list settings (elastic#33589) Add read-only Engine (elastic#33563) HLRC: Add ML get categories API (elastic#33465) SQL: Adds MONTHNAME, DAYNAME and QUARTER functions (elastic#33411) Add predicate_token_filter (elastic#33431) Fix Replace function. Adds more tests to all string functions. (elastic#33478) [ML] Rename input_fields to column_names in file structure (elastic#33568) Add full cluster restart base class (elastic#33577) Validate list values for settings (elastic#33503) Copy and validatie soft-deletes setting on resize (elastic#33517) Test: Fix package name SQL: Fix result column names for arithmetic functions (elastic#33500) Upgrade to latest Lucene snapshot (elastic#33505) Enable not wiping cluster settings after REST test (elastic#33575) MINOR: Remove Dead Code in SearchScript (elastic#33569) [Test] Remove duplicate method in TestShardRouting (elastic#32815) mute test on windows Update beats template to include apm-server metrics (elastic#33286) ...
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Dec 18, 2018
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 2, 2019
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 24, 2019
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 25, 2019
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 25, 2019
* support predicate_token_filter elastic/elasticsearch#33431 * add new file * fix failing unit tests
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 25, 2019
* support predicate_token_filter elastic/elasticsearch#33431 * add new file * fix failing unit tests
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 25, 2019
* support predicate_token_filter elastic/elasticsearch#33431 * add new file * fix failing unit tests
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 28, 2019
* support predicate_token_filter elastic/elasticsearch#33431 * add new file * fix failing unit tests (cherry picked from commit 6d5340b)
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Mar 29, 2019
* support predicate_token_filter elastic/elasticsearch#33431 * add new file * fix failing unit tests (cherry picked from commit 6d5340b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users to filter out terms using scripted predicates, rather than having to write Java code and wiring things up via analysis plugins.