Skip to content

Docs: Add password keystore setting for email account passwords#33409

Merged
spinscale merged 3 commits intoelastic:masterfrom
spinscale:1809-watcher-fix-email-docs-secure-password
Dec 6, 2018
Merged

Docs: Add password keystore setting for email account passwords#33409
spinscale merged 3 commits intoelastic:masterfrom
spinscale:1809-watcher-fix-email-docs-secure-password

Conversation

@spinscale
Copy link
Copy Markdown
Contributor

The keystore configuration options have not been mentioned yet, but have so in hipchat/jira/pagerduty actions.

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra

Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments.


In order to not store the account SMTP password as plaintext in the
elasticsearch yaml file, you should use the keystore instead (you can still
store the password in the elasticsearch configuration file, if you need to)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have this node about putting the password in elasticsearch.yml. This should be going away; we shouldn't be promoting it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed that mention

--------------------------------------------------

In order to not store the account SMTP password as plaintext in the
elasticsearch yaml file, you should use the keystore instead (you can still
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should crosslink to the keystore docs ("secure settings").

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rjernst rjernst removed the review label Oct 10, 2018
@colings86 colings86 added v6.6.0 and removed v6.5.0 labels Oct 25, 2018
Copy link
Copy Markdown
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spinscale spinscale merged commit 97259f0 into elastic:master Dec 6, 2018
spinscale added a commit that referenced this pull request Dec 6, 2018
Always refer to secure settings when setting up email account passwords
spinscale added a commit that referenced this pull request Dec 6, 2018
Always refer to secure settings when setting up email account passwords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants