Build: Merge xpack checkstyle config into core#33399
Merged
nik9000 merged 2 commits intoelastic:masterfrom Sep 5, 2018
Merged
Conversation
Merges the xpack checkstyle_suppressions.xml file into the core checkstyle_suppressions.xml file. We needed two files in the past because we had two repositories. Now that we have one we can use just one.
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
requested changes
Sep 4, 2018
Member
jasontedor
left a comment
There was a problem hiding this comment.
This list is so short, we could conceivably clean these up and remove the suppressions rather than moving them to core where they will be lost? At least then a major part of our codebase (x-pack) would be free of suppressions?
Member
Author
I'll check. |
Member
Author
Done. |
Member
Author
I am, indeed, awesome. |
Member
Author
|
Thanks for reviewing @rjernst and @jasontedor . |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 5, 2018
* master: Fix deprecated setting specializations (elastic#33412) HLRC: split cluster request converters (elastic#33400) HLRC: Add ML get influencers API (elastic#33389) Add conditional token filter to elasticsearch (elastic#31958) Build: Merge xpack checkstyle config into core (elastic#33399) Disable IndexRecoveryIT.testRerouteRecovery. INGEST: Implement Drop Processor (elastic#32278) [ML] Add field stats to log structure finder (elastic#33351) Add interval response parameter to AutoDateInterval histogram (elastic#33254) MINOR+CORE: Remove Dead Methods ClusterService (elastic#33346)
nik9000
added a commit
that referenced
this pull request
Sep 5, 2018
Solves all of the xpack line length suppressions and then merges the remainder of the xpack checkstyle_suppressions.xml file into the core checkstyle_suppressions.xml file. At this point that just means the antlr generated files for sql. It also adds an exclusion to the line length tests for javadocs that are just a URL. We have one such javadoc and breaking up the line would make the link difficult to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the xpack checkstyle_suppressions.xml file into the core
checkstyle_suppressions.xml file. We needed two files in the past
because we had two repositories. Now that we have one we can use just
one.