SECURITY: Fix Compile Error in ReservedRealmTests#33166
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Aug 27, 2018
original-brownbear:fix-xpack-compile
Merged
SECURITY: Fix Compile Error in ReservedRealmTests#33166original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:fix-xpack-compile
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:fix-xpack-compile
Conversation
* This was broken by #32515 since the 5.x versions were removed between PR creation and merge
Collaborator
|
Pinging @elastic/es-security |
jasontedor
approved these changes
Aug 27, 2018
Member
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. You can push this immediately to get compilation fixed.
ycombinator
approved these changes
Aug 27, 2018
Contributor
ycombinator
left a comment
There was a problem hiding this comment.
LGTM. Thanks for catching and fixing!
Contributor
Author
|
@jasontedor @ycombinator thanks, merging right away then:) |
jasontedor
added a commit
that referenced
this pull request
Aug 27, 2018
* master: Adjust BWC version on mapping version Token API supports the client_credentials grant (#33106) Build: forked compiler max memory matches jvmArgs (#33138) Introduce mapping version to index metadata (#33147) SQL: Enable aggregations to create a separate bucket for missing values (#32832) Fix grammar in contributing docs SECURITY: Fix Compile Error in ReservedRealmTests (#33166) APM server monitoring (#32515) Support only string `format` in date, root object & date range (#28117) [Rollup] Move toBuilders() methods out of rollup config objects (#32585) Fix forbiddenapis on java 11 (#33116) Apply publishing to genreate pom (#33094) Have circuit breaker succeed on unknown mem usage Do not lose default mapper on metadata updates (#33153) Fix a mappings update test (#33146) Reload Secure Settings REST specs & docs (#32990) Refactor CachingUsernamePassword realm (#32646)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
were removed between PR creation and merge