[docs] Remove repeating words#33087
Merged
cbuescher merged 2 commits intoelastic:masterfrom Aug 28, 2018
Merged
Conversation
Contributor
|
@elasticmachine test this please |
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@jtibshirani thanks for starting a build! I see that the CI failed with an error. I am not familiar with the build process, but going out on a limb, I would assume that the failure is not caused by this PR (only .asciidoc changes). Can somebody have a look why the build failed? Agent running out of space? Another issue bubbling up? Thanks! |
Contributor
|
Yes, these are definitely not due to your build causing failures. That was due to a version bump upgrade that takes time to sort out before builds go green again. We did just merge another BWC affecting change, and you need to have it in this branch before tests pass. If you just run the following, substitutuing out After merging in the upstream commits, just push to your branch to update the PR and we can kick off a CI run. |
Contributor
Author
|
@hub-cap thanks for looking into this! And explaining what went wrong:) PR updated. |
cbuescher
approved these changes
Aug 28, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
LGTM, I don't think this needs another CI run since there are no changes here that affect any tests or docs tests. I just built the docs itself and that looks okay. Will merge this in.
cbuescher
pushed a commit
that referenced
this pull request
Aug 28, 2018
cbuescher
pushed a commit
that referenced
this pull request
Aug 28, 2018
Contributor
Author
|
Thanks @cbuescher :) |
dnhatn
added a commit
that referenced
this pull request
Aug 28, 2018
* master: [Rollup] Better error message when trying to set non-rollup index (#32965) HLRC: Use Optional in validation logic (#33104) Remove unused User class from protocol (#33137) ingest: Introduce the dissect processor (#32884) [Docs] Add link to es-kotlin-wrapper-client (#32618) [Docs] Remove repeating words (#33087) Minor spelling and grammar fix (#32931) Remove support for deprecated params._agg/_aggs for scripted metric aggregations (#32979) Watcher: Simplify finding next date in cron schedule (#33015) Run Third party audit with forbidden APIs CLI (part3/3) (#33052) Fix plugin build test on Windows (#33078) HLRC+MINOR: Remove Unused Private Method (#33165) Remove old unused test script files (#32970) Build analysis-icu client JAR (#33184) Ensure to generate identical NoOp for the same failure (#33141) ShardSearchFailure#readFrom to set index and shardId (#33161)
dnhatn
added a commit
that referenced
this pull request
Aug 28, 2018
* 6.x: [Rollup] Better error message when trying to set non-rollup index (#32965) Remove unused User class from protocol (#33137) [DOCS] Adds link to 6.3.0 release highlights Test: fix token bwc tests due to bad backport Ensure to generate identical NoOp for the same failure (#33141) [Docs] Add link to es-kotlin-wrapper-client (#32618) [Docs] Remove repeating words (#33087) Minor spelling and grammar fix (#32931) Run Third party audit with forbidden APIs CLI (part3/3) (#33052) Fix plugin build test on Windows (#33078) Watcher: Simplify finding next date in cron schedule (#33015) Remove old unused test script files (#32970) Build analysis-icu client JAR (#33184) Switch remaining tests to new style Requests (#33109) Use internal connection manager when fetching remote node info Switch remaining x-pack tests to new style Requests (#33108) Switch remaining ml tests to new style Requests (#33107) Token API supports the client_credentials grant (#33106)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial change removing repeating words from a few docs