Clarify ignore_above behavior with arrays of strings#33057
Merged
dliappis merged 2 commits intoelastic:masterfrom Aug 22, 2018
Merged
Clarify ignore_above behavior with arrays of strings#33057dliappis merged 2 commits intoelastic:masterfrom
dliappis merged 2 commits intoelastic:masterfrom
Conversation
and also note that all string(s) will still be visible in the `_source` field.
Collaborator
|
Pinging @elastic/es-search-aggs |
colings86
approved these changes
Aug 22, 2018
Contributor
colings86
left a comment
There was a problem hiding this comment.
LGTM, I left a minor comment but I don't feel strongly about it so happy for this to be merged with or without my suggestion applied
| === `ignore_above` | ||
|
|
||
| Strings longer than the `ignore_above` setting will not be indexed or stored. | ||
| For arrays of strings, `ignore_above` will be applied for each array element and string elements longer than `ignore_above` will not be indexed or stored. |
Contributor
There was a problem hiding this comment.
minor: maybe ...each array element separately and... would be clearer here?
Contributor
Author
There was a problem hiding this comment.
Fixed in eac5614 as per your suggestion, I think it looks clearer now WDYT?
Contributor
Author
|
Thanks a lot @colings86 for the blazingly fast review ; thoughts about how far back to go for the backport after CI is green? |
Contributor
|
I think just back to 6.3 is fine, since these are the active versions |
dliappis
added a commit
that referenced
this pull request
Aug 22, 2018
Currently docs don't explain how `ignore_above` behaves with arrays of strings. Clarify how `ignore_above` applies for arrays of strings and also note that all string(s) will still be visible in the `_source` field. Relates #33057
dliappis
added a commit
that referenced
this pull request
Aug 22, 2018
Currently docs don't explain how `ignore_above` behaves with arrays of strings. Clarify how `ignore_above` applies for arrays of strings and also note that all string(s) will still be visible in the `_source` field. Relates #33057
dliappis
added a commit
that referenced
this pull request
Aug 22, 2018
Currently docs don't explain how `ignore_above` behaves with arrays of strings. Clarify how `ignore_above` applies for arrays of strings and also note that all string(s) will still be visible in the `_source` field. Relates #33057
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and also note that all string(s) will still be visible in the
_sourcefield.