Adds explain lifecycle API to the Rest Client#32606
Merged
colings86 merged 10 commits intoelastic:index-lifecyclefrom Aug 9, 2018
colings86:ilm/rest-explain
Merged
Adds explain lifecycle API to the Rest Client#32606colings86 merged 10 commits intoelastic:index-lifecyclefrom colings86:ilm/rest-explain
colings86 merged 10 commits intoelastic:index-lifecyclefrom
colings86:ilm/rest-explain
Conversation
98 tasks
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@elasticmachine test this please |
dakrone
approved these changes
Aug 8, 2018
Member
dakrone
left a comment
There was a problem hiding this comment.
This LGTM, I left some requests for javadocs on the user-facing portion but no need for another review (once CI is happy)
| import java.util.function.Function; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class ExplainLifecycleResponse extends ActionResponse implements ToXContentObject { |
| this.indexResponses = indexResponses; | ||
| } | ||
|
|
||
| public Map<String, IndexLifecycleExplainResponse> getIndexResponses() { |
Member
There was a problem hiding this comment.
This method needs javadocs since I expect it to be user-facing
| import java.util.Arrays; | ||
| import java.util.Objects; | ||
|
|
||
| public class ExplainLifecycleRequest extends ClusterInfoRequest<ExplainLifecycleRequest> { |
|
|
||
| @Override | ||
| public String toString() { | ||
| return "Request [indices()=" + Arrays.toString(indices()) + ", indicesOptions()=" + indicesOptions() + "]"; |
Member
There was a problem hiding this comment.
Request -> ExplainLifecycleRequest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.