NETWORKING: Fix Netty Leaks by upgrading to 4.1.28#32511
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Aug 1, 2018
original-brownbear:32478
Merged
NETWORKING: Fix Netty Leaks by upgrading to 4.1.28#32511original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:32478
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:32478
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
* Upgrade to `4.1.28` since the problem reported in #32487 is a bug in Netty itself (see netty/netty#7337) * Fixed other leaks in test code that now showed up due to fixes improvements in leak reporting in the newer version * Needed to extend permissions for netty common package because it now sets a classloader at runtime after changes in netty/netty@63bae09 * Adjusted forbidden APIs check accordingly * Closes #32487
jasontedor
approved these changes
Jul 31, 2018
Member
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. If CI is happy, I am happy. This is so much better than the circus we had in #31232.
Contributor
Author
|
Jenkins test this |
Tim-Brooks
approved these changes
Jul 31, 2018
Contributor
Tim-Brooks
left a comment
There was a problem hiding this comment.
LGTM
The code does not really bother me since it is in unit tests. But it looks like netty does have a facility for releasing RCs in testing without try/finally.
http://netty.io/wiki/reference-counted-objects.html
public void testSomething() throws Exception {
// ReferenceCountUtil.releaseLater() will keep the reference of buf,
// and then release it when the test thread is terminated.
ByteBuf buf = ReferenceCountUtil.releaseLater(Unpooled.directBuffer(512));
...
}
I don't know how effective that is. But something to maybe look at in future fixes.
Contributor
Author
|
@tbrooks8 thanks! I'm just fixing those tests, so the leak detector doesn't go red :) |
dnhatn
added a commit
that referenced
this pull request
Aug 3, 2018
* master: HLRC: Move commercial clients from XPackClient (#32596) Add cluster UUID to Cluster Stats API response (#32206) Security: move User to protocol project (#32367) [TEST] Test for shard failures, add debug to testProfileMatchesRegular Minor fix for javadoc (applicable for java 11). (#32573) Painless: Move Some Lookup Logic to PainlessLookup (#32565) TEST: Avoid merges in testSeqNoAndCheckpoints [Rollup] Remove builders from HistoGroupConfig (#32533) Mutes failing SQL string function tests due to #32589 fixed elements in array of produced terms (#32519) INGEST: Enable default pipelines (#32286) Remove cluster state initial customs (#32501) Mutes LicensingDocumentationIT due to #32580 [ML] Remove multiple_bucket_spans (#32496) [ML] Rename JobProvider to JobResultsProvider (#32551) Correct minor typo in explain.asciidoc for HLRC Build: Add elastic maven to repos used by BuildPlugin (#32549) Clarify the error message when a pipeline agg is used in the 'order' parameter. (#32522) Revert "[test] turn on host io cache for opensuse (#32053)" Enable packaging tests on suse boxes [ML] Improve error when no available field exists for rule scope (#32550) [ML] Improve error for functions with limited rule condition support (#32548) Painless: Clean Up PainlessField (#32525) Add @AwaitsFix for #32554 Remove broken @link in Javadoc Scripting: Conditionally use java time api in scripting (#31441) [ML] Fix thread leak when waiting for job flush (#32196) (#32541) Add AwaitsFix to failing test - see #32546 Core: Minor size reduction for AbstractComponent (#32509) SQL: Added support for string manipulating functions with more than one parameter (#32356) [DOCS] Reloadable Secure Settings (#31713) Watcher: Reenable HttpSecretsIntegrationTests#testWebhookAction test (#32456) [Rollup] Remove builders from TermsGroupConfig (#32507) Use hostname instead of IP with SPNEGO test (#32514) Switch x-pack rolling restart to new style Requests (#32339) NETWORKING: Fix Netty Leaks by upgrading to 4.1.28 (#32511) [DOCS] Small fixes in rule configuration page (#32516) Painless: Clean up PainlessMethod (#32476) Build: Remove shadowing from benchmarks (#32475) Docs: Add all JDKs to CONTRIBUTING.md Add licensing enforcement for FIPS mode (#32437) SQL: Add test for handling of partial results (#32474) Mute testFilterCacheStats [ML][DOCS] Fix typo applied_to => applies_to Scripting: Fix painless compiler loader to know about context classes (#32385)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.1.28since the problem reported in [CI] SslIntegrationTests fail with Netty buffer leak #32487 is a bug in Netty itself (see Possible buffer leak in SslHandler? netty/netty#7337)