Make various LifecycleSettings Settings internal#32381
Merged
dakrone merged 5 commits intoelastic:index-lifecyclefrom Jul 30, 2018
Merged
Make various LifecycleSettings Settings internal#32381dakrone merged 5 commits intoelastic:index-lifecyclefrom
dakrone merged 5 commits intoelastic:index-lifecyclefrom
Conversation
These are only ever set internally during regular ILM execution, they don't need to be set otherwise. A subsequent PR will work on adding a dedicated endpoint for the `LIFECYCLE_NAME` setting so it can be changed by a user (and then marked as `InternalIndex` as well) Relates to elastic#29823
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
@elasticmachine retest this please |
colings86
reviewed
Jul 26, 2018
| Setting.Property.IndexScope, Setting.Property.NotCopyableOnResize, Setting.Property.InternalIndex); | ||
| public static final Setting<Boolean> LIFECYCLE_SKIP_SETTING = Setting.boolSetting(LIFECYCLE_SKIP, false, | ||
| Setting.Property.Dynamic, Setting.Property.IndexScope); | ||
| Setting.Property.Dynamic, Setting.Property.IndexScope, Setting.Property.InternalIndex); |
Contributor
There was a problem hiding this comment.
This setting should not be internal as currently there is no API to set it other than the update settings API. I actually think that now we have the operation mode API we should remove this
Contributor
There was a problem hiding this comment.
I guess I assumed tests would fail, guess this wasn't tested thoroughly enough. I can remove this in a follow-up
…ifecycle-settings-internal
jasontedor
pushed a commit
that referenced
this pull request
Aug 17, 2018
These are only ever set internally during regular ILM execution, they don't need to be set otherwise. A subsequent PR will work on adding a dedicated endpoint for the `LIFECYCLE_NAME` setting so it can be changed by a user (and then marked as `InternalIndex` as well) Relates to #29823
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are only ever set internally during regular ILM execution, they don't need
to be set otherwise.
A subsequent PR will work on adding a dedicated endpoint for the
LIFECYCLE_NAMEsetting so it can be changed by a user (and then marked asInternalIndexas well)Relates to #29823