Skip to content

Remove "best_compression" option from the ForceMergeAction#32373

Merged
dakrone merged 1 commit intoelastic:index-lifecyclefrom
dakrone:ilm-remove-best-compression
Jul 25, 2018
Merged

Remove "best_compression" option from the ForceMergeAction#32373
dakrone merged 1 commit intoelastic:index-lifecyclefrom
dakrone:ilm-remove-best-compression

Conversation

@dakrone
Copy link
Copy Markdown
Member

@dakrone dakrone commented Jul 25, 2018

This option is only settable while the index is closed, and doesn't make sense
for a force merge.

Relates to #29823

This option is only settable while the index is closed, and doesn't make sense
for a force merge.

Relates to elastic#29823
@dakrone dakrone added the :Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. label Jul 25, 2018
@dakrone dakrone requested review from colings86 and talevy July 25, 2018 17:54
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra

Copy link
Copy Markdown
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakrone dakrone merged commit 3daefe6 into elastic:index-lifecycle Jul 25, 2018
jasontedor pushed a commit that referenced this pull request Aug 17, 2018
This option is only settable while the index is closed, and doesn't make sense
for a force merge.

Relates to #29823
@dakrone dakrone deleted the ilm-remove-best-compression branch February 4, 2019 14:46
@wandermyz
Copy link
Copy Markdown

I was wondering if it’s removed from force merge step, in which step do I specify best_compression during the whole lifecycle?

@talevy
Copy link
Copy Markdown
Contributor

talevy commented May 3, 2019

Hi @wandermyz, There isn't a place in ILM that allows one to specify best_compression.

Since closing this issue, we've improved both the infrastructure and experience of ILM actions, so I think that Elasticsearch may be open to re-introducing this in the future.

@AthenaEryma
Copy link
Copy Markdown
Contributor

We already have an issue open to add this back to ILM: #41274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants