[TEST] Fix failure due to exception message in java11#32321
Merged
polyfractal merged 2 commits intoelastic:masterfrom Jul 25, 2018
Merged
[TEST] Fix failure due to exception message in java11#32321polyfractal merged 2 commits intoelastic:masterfrom
polyfractal merged 2 commits intoelastic:masterfrom
Conversation
Java 11 uses more verbose exceptions messages, causing this assertion to fail. Changed the test to be less restrictive and only look for the classes we care about.
Collaborator
|
Pinging @elastic/es-search-aggs |
cbuescher
requested changes
Jul 24, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
Thanks, I left a small request.
| @@ -510,8 +510,10 @@ public void testMismatch() throws IOException { | |||
| InternalAggregation.ReduceContext reduceContext = new InternalAggregation.ReduceContext(bigArrays, scriptService, true); | |||
| Exception e = expectThrows(RuntimeException.class, | |||
Member
There was a problem hiding this comment.
Can this be more specific so that we at least check the expected exception type? By checking the exception message I think we at least used to expect a ClassCastException or something alike. Would be great if we can to that here now that the assertion on the exact message text needs to be relaxed a bit.
Contributor
Author
There was a problem hiding this comment.
Oops, good catch. Should have been like that before anyway.
dnhatn
added a commit
that referenced
this pull request
Jul 26, 2018
* master: [DOCS] Fix formatting error in Slack action Painless: Fix documentation links to use existing refs (#32335) Painless: Decouple PainlessLookupBuilder and Whitelists (#32346) [DOCS] Adds recommendation for xpack.security.enabled (#32345) [TEST] Mute ConvertProcessortTests.testConvertIntHexError [TEST] Fix failure due to exception message in java11 (#32321) [DOCS] Fixes typo in ML aggregations page [DOCS] Adds link from bucket_span property to common time units [ML][DOCS] Add documentation for detector rules and filters (#32013) Add opaque_id to index audit logging (#32260) Add 6.5.0 version to master fixes broken build for third-party-tests (#32353)
jimczi
pushed a commit
that referenced
this pull request
Oct 4, 2018
Java 11 uses more verbose exceptions messages, causing this assertion to fail. Changed the test to be less restrictive and only look for the classes we care about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cbuescher looks like CI turned up another variation of #32036, this time in rollup tests :)
Changed the test to be less restrictive and only look for the classes we care about, so that we don't fail on java 11 with more verbose exception messages.