Scripting: Remove Dead Code from Painless Module#32064
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Jul 16, 2018
original-brownbear:remove-deadcode-painless
Merged
Scripting: Remove Dead Code from Painless Module#32064original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:remove-deadcode-painless
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:remove-deadcode-painless
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
jdconrad
approved these changes
Jul 16, 2018
Contributor
jdconrad
left a comment
There was a problem hiding this comment.
LGTM as well. writeBranch was left behind by a performance optimization that was considered unnecessary at the time. I assume StashingTokenFactory was used as part of regex parsing, but @nik9000 knows the history there better than I do.
Member
I believe I used it for the hacks that inserted semicolons actually but you replaced my hacks with nicer parsing code. |
Contributor
Author
Contributor
|
@original-brownbear Yes, 6.x as well. Thanks for fixing this! |
martijnvg
added a commit
that referenced
this pull request
Jul 16, 2018
* es/master: (21 commits) Tweaked Elasticsearch Service links for SEO Watcher: Store username on watch execution (#31873) Use correct formatting for links (#29460) Painless: Separate PainlessLookup into PainlessLookup and PainlessLookupBuilder (#32054) Scripting: Remove dead code from painless module (#32064) [Rollup] Replace RollupIT with a ESRestTestCase version (#31977) [TEST] Consistent algorithm usage (#32077) [Rollup] Fix duplicate field names in test (#32075) Ensure only parent breaker trips in unit test Unmute field collapsing rest tests Fix BWC check after backport [Tests] Fix failure due to changes exception message (#32036) Remove unused params from SSource and Walker (#31935) [Test] Mute MlJobIT#testDeleteJobAfterMissingAliases Turn off real-mem breaker in REST tests Turn off real-mem breaker in single node tests Fix broken OpenLDAP Vagrant QA test Cleanup Duplication in `PainlessScriptEngine` (#31991) SCRIPTING: Remove unused MultiSearchTemplateRequestBuilder (#32049) Fix compile issues introduced by merge (#32058) ...
original-brownbear
added a commit
that referenced
this pull request
Jul 17, 2018
martijnvg
added a commit
that referenced
this pull request
Jul 17, 2018
* es/6.x: Scripting: Remove dead code from painless module (#32064) (#32104) Painless: Move and Rename Several Methods in the lookup package (#32105) Bypass highlight query terms extraction on empty fields (#32090) Core: Backport java time date formatters (#31997) Switch non-x-pack to new style requests (#32106) SQL: allow LEFT and RIGHT as function names (#32066) Painless: Separate PainlessLookup into PainlessLookup and PainlessLookupBuilder (#32054) [test] turn on host io cache for opensuse (#32053) DOCS: put LIMIT 10 to the SQL query (#32065)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither this method nor the removed class are used anymore.