Correct spelling of AnalysisPlugin#requriesAnalysisSettings#32025
Merged
romseygeek merged 2 commits intoelastic:masterfrom Jul 13, 2018
romseygeek:analysis-typo
Merged
Correct spelling of AnalysisPlugin#requriesAnalysisSettings#32025romseygeek merged 2 commits intoelastic:masterfrom romseygeek:analysis-typo
romseygeek merged 2 commits intoelastic:masterfrom
romseygeek:analysis-typo
Conversation
Because this is a static method on a public API, and one that we encourage plugin authors to use, the method with the typo is deprecated in 6.x rather than just renamed.
Collaborator
|
Pinging @elastic/es-search-aggs |
Contributor
Author
|
I added a note to |
martijnvg
approved these changes
Jul 13, 2018
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM
I added a note to docs/reference/migration/migrate_7_0/plugins.asciidoc as this seemed the best fit
👍
romseygeek
added a commit
that referenced
this pull request
Jul 13, 2018
Because this is a static method on a public API, and one that we encourage plugin authors to use, the method with the typo is deprecated in 6.x rather than just renamed.
dnhatn
added a commit
that referenced
this pull request
Jul 13, 2018
* 6.x: Watcher: Make settings reloadable (#31746) [Rollup] Histo group config should support scaled_floats (#32048) lazy snapshot repository initialization (#31606) Add secure setting for watcher email password (#31620) Watcher: cleanup ensureWatchExists use (#31926) Add second level of field collapsing (#31808) Added lenient flag for synonym token filter (#31484) (#31970) Test: Fix a second case of bad watch creation [Rollup] Use composite's missing_bucket (#31402) Docs: Restyled cloud link in getting started Docs: Change formatting of Cloud options Re-instate link in StringFunctionUtils javadocs Correct spelling of AnalysisPlugin#requriesAnalysisSettings (#32025) Fix problematic chars in javadoc [ML] Move open job failure explanation out of root cause (#31925) [ML] Switch ML native QA tests to use a 3 node cluster (#32011)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a public helper method in an API that plugin authors are encouraged to use, so we need to
deprecate the method name in 6.x and only remove it in master.