Get snapshot rest client cleanups#31740
Merged
Tim-Brooks merged 4 commits intoelastic:masterfrom Jul 5, 2018
Merged
Conversation
This is a followup to elastic#31537. It makes a number of changes requested by a review that came after the PR was merged. These are mostly cleanups and doc improvements.
Collaborator
|
Pinging @elastic/es-core-infra |
javanna
approved these changes
Jul 4, 2018
Contributor
javanna
left a comment
There was a problem hiding this comment.
left a tiny comment, LGTM otherwise, thanks @tbrooks8 !
| SnapshotState snapshotState = snapshotInfo.state(); | ||
| List<SnapshotShardFailure> snapshotShardFailures = snapshotInfo.shardFailures(); | ||
| long startTime = snapshotInfo.startTime(); | ||
| long endTime = snapshotInfo.endTime(); |
Contributor
There was a problem hiding this comment.
would be nice here to also add some corresponding instructions in the docs page.
dnhatn
added a commit
that referenced
this pull request
Jul 7, 2018
* master: [ML] Fix master node deadlock during ML daily maintenance (#31836) Build: Switch integ-test-zip to OSS-only (#31866) SQL: Remove restriction for single column grouping (#31818) Build: Fix detection of Eclipse Compiler Server (#31838) Docs: Inconsistency between description and example (#31858) Re-enable bwc tests now that #29538 has been backported and 6.x intake build succeeded. QA: build improvements related to SQL projects (#31862) [Docs] Add clarification to analysis example (#31826) Check timeZone() argument in AbstractSqlQueryRequest (#31822) SQL: Fix incorrect HAVING equality (#31820) Smaller aesthetic fixes to InternalTestCluster (#31831) [Docs] Clarify accepted sort case (#31605) Temporarily disable bwc test in order to backport #29538 Remove obsolete parameters from analyze rest spec (#31795) [Docs] Fix wrong link in Korean analyzer docs (#31815) Fix profiling of ordered terms aggs (#31814) Properly mute test involving JDK11 closes #31739 Do not return all indices if a specific alias is requested via get aliases api. (#29538) Get snapshot rest client cleanups (#31740) Docs: Explain _bulk?refresh shard targeting Fix handling of points_only with term strategy in geo_shape (#31766)
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Jul 11, 2018
This is a followup to elastic#31537. It makes a number of changes requested by a review that came after the PR was merged. These are mostly cleanups and doc improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #31537. It makes a number of changes requested by
a review that came after the PR was merged. These are mostly cleanups
and doc improvements.