REST high-level client: add get index API#31703
Merged
nik9000 merged 2 commits intoelastic:masterfrom Jul 5, 2018
Merged
Conversation
Member
|
@elasticmachine add to whitelist |
Collaborator
|
Pinging @elastic/es-core-infra |
80 tasks
89a0907 to
e9e08f7
Compare
javanna
reviewed
Jul 4, 2018
| * @return the response | ||
| * @throws IOException in case there is a problem sending the request or parsing back the response | ||
| */ | ||
| public GetIndexResponse getIndex(GetIndexRequest getIndexRequest, RequestOptions options) throws IOException { |
Contributor
There was a problem hiding this comment.
can you call it just get please ?
javanna
reviewed
Jul 4, 2018
| params.withLocal(getIndexRequest.local()); | ||
| params.withIncludeDefaults(getIndexRequest.includeDefaults()); | ||
| params.withHuman(getIndexRequest.humanReadable()); | ||
| params.withMasterTimeout(getIndexRequest.masterNodeTimeout()); |
Contributor
There was a problem hiding this comment.
can you also add this parameter to the corresponding REST spec? We are missing it there I think.
Contributor
Author
There was a problem hiding this comment.
I don't understand what you mean by the REST spec? You mean the documentation for get_index?
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Thanks! Now I know what this mysterious "spec" is every time you mention it 😀
Contributor
There was a problem hiding this comment.
👍 haha I thought I had explained that, sorry for the confusion.
-- Also added master_timeout parameter for the indices.get spec
javanna
approved these changes
Jul 5, 2018
Contributor
javanna
left a comment
There was a problem hiding this comment.
LGTM thanks @nik9000 & @sohaibiftikhar !
dnhatn
added a commit
that referenced
this pull request
Jul 5, 2018
* master: REST high-level client: add get index API (#31703) SQL: Allow long literals (#31777) SQL: Fix incorrect message for aliases (#31792) Test: Do not remove xpack templates when cleaning (#31642) Reduce more raw types warnings (#31780) Add unreleased version 6.3.2 Scripting: Remove support for deprecated StoredScript contexts (#31394) [ML][TEST] Use java 11 valid time format in DataDescriptionTests (#31817) [ML] Don't treat stale FAILED jobs as OPENING in job allocation (#31800) [ML] Fix calendar and filter updates from non-master nodes (#31804) Fix license header generation on Windows (#31790) mark RollupIT.testTwoJobsStartStopDeleteOne as AwaitsFix mark SearchAsyncActionTests.testFanOutAndCollect as AwaitsFix Correct exclusion of test on JDK 11 Fix doclint jdk 11 Add JDK11 support and enable in CI (#31644) Watcher: Fix check for currently executed watches (#31137) Watcher: Ensure correct method is used to read secure settings (#31753) SQL: Update CLI logo
nik9000
pushed a commit
that referenced
this pull request
Jul 5, 2018
Also added master_timeout parameter for the indices.get spec Relates to #27205
Member
|
Merge and backported to 6.x. |
dnhatn
added a commit
that referenced
this pull request
Jul 7, 2018
* 6.x: [ML] Fix master node deadlock during ML daily maintenance (#31836) Build: Switch integ-test-zip to OSS-only (#31866) Build: Fix detection of Eclipse Compiler Server (#31838) SQL: Remove restriction for single column grouping (#31818) Docs: Inconsistency between description and example (#31858) Fix and reenable TribeIntegrationTests QA: build improvements related to SQL projects (#31862) muted test [Docs] Add clarification to analysis example (#31826) Check timeZone() argument in AbstractSqlQueryRequest (#31822) Remove obsolete parameters from analyze rest spec (#31795) SQL: Fix incorrect HAVING equality (#31820) Smaller aesthetic fixes to InternalTestCluster (#31831) [Docs] Clarify accepted sort case (#31605) Do not return all indices if a specific alias is requested via get aliases api. (#29538) [Docs] Fix wrong link in Korean analyzer docs (#31815) Fix profiling of ordered terms aggs (#31814) Fix handling of points_only with term strategy in geo_shape (#31766) Docs: Explain _bulk?refresh shard targeting REST high-level client: add get index API (#31703)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #27205
This is a followup to #31675.