Adds an API to remove ILM from an index completely#31358
Merged
colings86 merged 2 commits intoelastic:index-lifecyclefrom Jun 21, 2018
colings86:ilm/remove-policy
Merged
Adds an API to remove ILM from an index completely#31358colings86 merged 2 commits intoelastic:index-lifecyclefrom colings86:ilm/remove-policy
colings86 merged 2 commits intoelastic:index-lifecyclefrom
colings86:ilm/remove-policy
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
talevy
reviewed
Jun 19, 2018
Contributor
There was a problem hiding this comment.
should this be a DELETE and we drop the remove_policy?
Contributor
There was a problem hiding this comment.
nevermind, that feels wrong after I typed (and sent it)
Contributor
|
Overall LGTM, will wait for a merge from index-lifecycle to give it another look |
The removal will only happen if the index is not in the shrink action
jasontedor
pushed a commit
that referenced
this pull request
Aug 17, 2018
* Adds an API to remove ILM from an index completely The removal will only happen if the index is not in the shrink action * Fixes compile issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removal will only happen if the index is not in the shrink action
I am not convinced the endpoint
PUT {index}/_index_lifecycle/remove_policyis right here. It feels like this should be an endpoint with a DELETE method. I also think it might be misleading since the endpoint does more than remove the policy, it removes all ILM settings from the index. So maybe it would be better to have the endpoint asDELETE {index}/_index_lifecycleinstead?I also wonder if the set policy endpoint should actually be
PUT {index}/_index_lifecycle/policy/{policy_name}instead of the currentPUT{index}/_index_lifecycle/set_policy/{policy_name}`?