Add package pre-install check for java binary by hub-cap · Pull Request #31343 · elastic/elasticsearch

hub-cap · 2018-06-14T19:49:42Z

The package installation relies on java being in the path. If java is
not in the path, the tests fail at post-install time. This commit adds a
pre-install check to validate that java exists, and if it fails, the
package is never installed, and thus keeps a system clean, rather than
aborting at post-install and leaving behind a mess.

Closes #29665

The package installation relies on java being in the path. If java is not in the path, the tests fail at post-install time. This commit adds a pre-install check to validate that java exists, and if it fails, the package is never installed, and thus keeps a system clean, rather than aborting at post-install and leaving behind a mess. Closes elastic#29665

elasticmachine · 2018-06-14T19:49:44Z

Pinging @elastic/es-core-infra

jasontedor

Looks great; I left one question. Thanks for picking this up.

jasontedor · 2018-06-14T19:57:12Z

distribution/packages/src/common/scripts/preinst

+    JAVA=`which java`
+fi
+
+if [ ! -x "$JAVA" ]; then


Does this ever execute in a failing case? I think that these scripts are always executed with set +e or does it differ by packaging system? If we get here it's because $JAVA_HOME/bin/java exists which we set JAVA to, or which java failed and we should have exited?

yea i copied this from https://github.com/elastic/elasticsearch/blob/master/distribution/packages/src/deb/init.d/elasticsearch#L83-L94 , and i think the logic is wrong. Ill fix up.

Changed the bash test check to see if $JAVA is set.

jasontedor · 2018-06-14T19:57:37Z

distribution/packages/src/common/scripts/preinst

+fi
+
+if [ ! -x "$JAVA" ]; then
+    echo "Could not find any executable java binary. Please install java in your PATH or set JAVA_HOME"


If this block is needed we have could not find java; set JAVA_HOME or ensure java is in PATH in elasticsearch-env. Maybe we can be consistent?

jasontedor · 2018-06-14T19:57:56Z

qa/vagrant/src/test/resources/packaging/tests/30_deb_package.bats

+    move_java
+    run dpkg -i elasticsearch-oss-$(cat version).deb
+    output=$status
+    unmove_java


jasontedor · 2018-06-14T19:58:11Z

qa/vagrant/src/test/resources/packaging/tests/40_rpm_package.bats

+    move_java
+    run rpm -i elasticsearch-oss-$(cat version).rpm
+    output=$status
+    unmove_java


hub-cap · 2018-06-19T13:49:14Z

ping @jasontedor as I have fixed the check up.

* elastic/master: (92 commits) Reduce number of raw types warnings (elastic#31523) Migrate scripted metric aggregation scripts to ScriptContext design (elastic#30111) turn GetFieldMappingsResponse to ToXContentObject (elastic#31544) Close xcontent parsers (partial) (elastic#31513) Ingest Attachment: Upgrade Tika to 1.18 (elastic#31252) TEST: Correct the assertion arguments order (elastic#31540) Add get field mappings to High Level REST API Client (elastic#31423) [DOCS] Updates Watcher examples for code testing (elastic#31152) TEST: Add bwc recovery tests with synced-flush index [DOCS] Move sql to docs (elastic#31474) [DOCS] Move monitoring to docs folder (elastic#31477) Core: Combine doExecute methods in TransportAction (elastic#31517) IndexShard should not return null stats (elastic#31528) fix repository update with the same settings but different type (elastic#31458) Fix Mockito trying to mock IOException that isn't thrown by method (elastic#31433) (elastic#31527) Node selector per client rather than per request (elastic#31471) Core: Combine messageRecieved methods in TransportRequestHandler (elastic#31519) Upgrade to Lucene 7.4.0. (elastic#31529) [ML] Add ML filter update API (elastic#31437) Allow multiple unicast host providers (elastic#31509) ...

jasontedor

LGTM.

The package installation relies on java being in the path. If java is not in the path, the tests fail at post-install time. This commit adds a pre-install check to validate that java exists, and if it fails, the package is never installed, and thus keeps a system clean, rather than aborting at post-install and leaving behind a mess. Closes #29665

* 6.x: Fix broken backport of #31578 by adjusting constructor (#31587) ingest: Add ignore_missing property to foreach filter (#22147) (#31578) Add package pre-install check for java binary (#31343) Docs: Clarify sensitive fields watcher encryption (#31551) Watcher: Remove never executed code (#31135) Improve test times for tests using `RandomObjects::addFields` (#31556) Revert "Remove RestGetAllAliasesAction (#31308)" REST high-level client: add simulate pipeline API (#31158) Get Mapping API to honour allow_no_indices and ignore_unavailable (#31507) Fix Mockito trying to mock IOException that isn't thrown by method (#31433) (#31527) [Test] Add full cluster restart test for Rollup (#31533) Enhance thread context uniqueness assertion fix writeIndex evaluation for aliases (#31562) Add x-opaque-id to search slow logs (#31539) Watcher: Fix put watch action (#31524) [DOCS] Significantly improve SQL docs turn GetFieldMappingsResponse to ToXContentObject (#31544) TEST: Unmute testHistoryUUIDIsGenerated Ingest Attachment: Upgrade Tika to 1.18 (#31252) TEST: Correct the assertion arguments order (#31540)

* master: ingest: Add ignore_missing property to foreach filter (#22147) (#31578) Fix a formatting issue in the docvalue_fields documentation. (#31563) reduce log level at gradle configuration time [TEST] Close additional clients created while running yaml tests (#31575) Docs: Clarify sensitive fields watcher encryption (#31551) Watcher: Remove never executed code (#31135) Add support for switching distribution for all integration tests (#30874) Improve robustness of geo shape parser for malformed shapes (#31449) QA: Create xpack yaml features (#31403) Improve test times for tests using `RandomObjects::addFields` (#31556) [Test] Add full cluster restart test for Rollup (#31533) Enhance thread context uniqueness assertion [DOCS] Fix heading format errors (#31483) fix writeIndex evaluation for aliases (#31562) Add x-opaque-id to search slow logs (#31539) Watcher: Fix put watch action (#31524) Add package pre-install check for java binary (#31343) Reduce number of raw types warnings (#31523) Migrate scripted metric aggregation scripts to ScriptContext design (#30111) turn GetFieldMappingsResponse to ToXContentObject (#31544) Close xcontent parsers (partial) (#31513) Ingest Attachment: Upgrade Tika to 1.18 (#31252) TEST: Correct the assertion arguments order (#31540)

This recreates a test that was added to the bats packaging tests in elastic#31343 but didn't make it over to the java project during when the linux package tests were ported in elastic#31943 When packages are installed but can not locate the java executable, they should fail with a descriptive message

This recreates a test that was added to the bats packaging tests in #31343 but didn't make it over to the java project during when the linux package tests were ported in #31943 When packages are installed but can not locate the java executable, they should fail with a descriptive message

This recreates a test that was added to the bats packaging tests in elastic#31343 but didn't make it over to the java project during when the linux package tests were ported in elastic#31943 When packages are installed but can not locate the java executable, they should fail with a descriptive message

This recreates a test that was added to the bats packaging tests in #31343 but didn't make it over to the java project during when the linux package tests were ported in #31943 When packages are installed but can not locate the java executable, they should fail with a descriptive message

hub-cap added >enhancement review :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v7.0.0 v6.4.0 v6.3.1 labels Jun 14, 2018

hub-cap added >bug and removed >enhancement labels Jun 14, 2018

jasontedor reviewed Jun 14, 2018

View reviewed changes

hub-cap added 2 commits June 15, 2018 15:01

Fix the bash test flag

442023c

Merge remote-tracking branch 'upstream/master' into fix_java_check

a1a1e2c

nik9000 approved these changes Jun 19, 2018

View reviewed changes

jasontedor added 2 commits June 25, 2018 11:48

Use same error message as elasticsearch-env

084f9ff

jasontedor approved these changes Jun 25, 2018

View reviewed changes

hub-cap merged commit adfcea2 into elastic:master Jun 25, 2018

hub-cap added the backport pending label Jun 25, 2018

hub-cap removed the backport pending label Jun 26, 2018

andyb-elastic mentioned this pull request Jul 20, 2018

[test] package pre-install java check #32259

Merged

colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

minfrin mentioned this pull request Dec 6, 2019

"could not find java; set JAVA_HOME" from Debian package install script breaks cloud-init, breaks automation #49948

Closed

mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add package pre-install check for java binary#31343

Add package pre-install check for java binary#31343
hub-cap merged 5 commits intoelastic:masterfrom
hub-cap:fix_java_check

hub-cap commented Jun 14, 2018

Uh oh!

elasticmachine commented Jun 14, 2018

Uh oh!

jasontedor left a comment

Uh oh!

jasontedor Jun 14, 2018

Uh oh!

hub-cap Jun 15, 2018

Uh oh!

hub-cap Jun 15, 2018

Uh oh!

jasontedor Jun 14, 2018

Uh oh!

jasontedor Jun 14, 2018

Uh oh!

jasontedor Jun 14, 2018

Uh oh!

hub-cap commented Jun 19, 2018

Uh oh!

jasontedor left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

hub-cap commented Jun 14, 2018

Uh oh!

elasticmachine commented Jun 14, 2018

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

jasontedor Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

hub-cap Jun 15, 2018

Choose a reason for hiding this comment

Uh oh!

hub-cap Jun 15, 2018

Choose a reason for hiding this comment

Uh oh!

jasontedor Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

jasontedor Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

jasontedor Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

hub-cap commented Jun 19, 2018

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants