More detailed tracing when writing metadata#31319
Merged
DaveCTurner merged 2 commits intoelastic:masterfrom Jun 14, 2018
Merged
More detailed tracing when writing metadata#31319DaveCTurner merged 2 commits intoelastic:masterfrom
DaveCTurner merged 2 commits intoelastic:masterfrom
Conversation
Packaging tests are occasionally failing (elastic#30295) because of very slow index template creation. It looks like the slow part is updating the on-disk cluster state, and this change will help to confirm this.
Collaborator
|
Pinging @elastic/es-distributed |
bleskes
approved these changes
Jun 14, 2018
Contributor
bleskes
left a comment
There was a problem hiding this comment.
LGTM. left some optional suggestions.
| // we are on the same FileSystem / Partition here we can do an atomic move | ||
| Files.move(tmpPath, finalPath, StandardCopyOption.ATOMIC_MOVE); | ||
| IOUtils.fsync(stateLocation, true); | ||
| logger.trace("copied state to {}", finalPath); |
Contributor
There was a problem hiding this comment.
do we want to do this after the deleteIfExists? for the odd case that deletes are slow?
Contributor
There was a problem hiding this comment.
Same question about tracing the cleanupOldFiles method run.
Member
Author
There was a problem hiding this comment.
Sure. It seems unlikely since these calls don't fsync(), but there's little harm in checking. I pushed 4fc8a94.
jasontedor
added a commit
to majormoses/elasticsearch
that referenced
this pull request
Jun 14, 2018
* elastic/master: More detailed tracing when writing metadata (elastic#31319) [Tests] Mutualize fixtures code in BaseHttpFixture (elastic#31210) Remove RestGetAllAliasesAction (elastic#31308) Temporary fix for broken build Reenable Checkstyle's unused import rule (elastic#31270) Remove remaining unused imports before merging elastic#31270 Fix non-REST doc snippet
Member
Author
|
Merged to |
tlrx
added a commit
that referenced
this pull request
Jun 15, 2018
* master: 992c788 Uncouple persistent task state and status (#31031) 8c6ee7d Describe how to add a plugin in Dockerfile (#31340) 1c5cec0 Remove http status code maps (#31350) 87a676e Do not set vm.max_map_count when unnecessary (#31285) e5b7137 TEST: getCapturedRequestsAndClear should be atomic (#31312) 0324103 Painless: Fix bug for static method calls on interfaces (#31348) d6d0727 QA: Fix resolution of default distribution (#31351) fcf1e41 Extract common http logic to server (#31311) 6dd81ea Build: Fix the license in the pom zip and tar (#31336) 8f886cd Treat ack timeout more like a publish timeout (#31303) 9b29327 [ML] Add description to ML filters (#31330) f7a0caf SQL: Fix build on Java 10 375d09c [TEST] Fix RemoteClusterClientTests#testEnsureWeReconnect 4877cec More detailed tracing when writing metadata (#31319) bbfe1ec [Tests] Mutualize fixtures code in BaseHttpFixture (#31210)
DaveCTurner
added a commit
that referenced
this pull request
Jun 15, 2018
Packaging tests are occasionally failing (#30295) because of very slow index template creation. It looks like the slow part is updating the on-disk cluster state, and this change will help to confirm this.
dnhatn
added a commit
that referenced
this pull request
Jun 15, 2018
* 6.x: Upgrade to Lucene-7.4.0-snapshot-518d303506 (#31360) [ML] Implement new rules design (#31110) (#31294) Remove RestGetAllAliasesAction (#31308) CCS: don't proxy requests for already connected node (#31273) Rankeval: Fold template test project into main module (#31203) [Docs] Remove reference to repository-s3 plugin creating an S3 bucket (#31359) More detailed tracing when writing metadata (#31319) Add details section for dcg ranking metric (#31177)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packaging tests are occasionally failing (#30295) because of very slow index
template creation. It looks like the slow part is updating the on-disk cluster
state, and this change will help to confirm this.