Skip to content

Add nio-transport as option for http smoke tests#31162

Merged
Tim-Brooks merged 1 commit intoelastic:masterfrom
Tim-Brooks:enable_nio_smoke_tests
Jun 7, 2018
Merged

Add nio-transport as option for http smoke tests#31162
Tim-Brooks merged 1 commit intoelastic:masterfrom
Tim-Brooks:enable_nio_smoke_tests

Conversation

@Tim-Brooks
Copy link
Copy Markdown
Contributor

@Tim-Brooks Tim-Brooks commented Jun 6, 2018

This is related to #27260 and #28898. This commit adds the transport-nio
plugin as a random option when running the http smoke tests. As part of
this PR, I identified an issue where cors support was not properly
enabled causing these tests to fail when using transport-nio. This
commit also fixes that issue.

This is related to elastic#27260 and elastic#28898. This commit adds the transport-nio
plugin as a random option when running the http smoke tests. As part of
this PR, I identified an issue where cors support was not properly
enabled causing these tests to fail when using transport-nio. This
commit also fixes that issue.
@Tim-Brooks Tim-Brooks added >non-issue review :Distributed/Network Http and internode communication implementations v7.0.0 labels Jun 6, 2018
@Tim-Brooks Tim-Brooks requested review from jasontedor and s1monw June 6, 2018 22:47
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra

Copy link
Copy Markdown
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Tim-Brooks Tim-Brooks merged commit 237f9b8 into elastic:master Jun 7, 2018
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jun 7, 2018
…tiges

* elastic/master:
  [DOCS] Fixes broken link in auditing settings
  QA: Better seed nodes for rolling restart
  [DOCS] Moves ML content to stack-docs
  [DOCS] Clarifies recommendation for audit index output type (elastic#31146)
  Add nio-transport as option for http smoke tests (elastic#31162)
  QA: Set better node names on rolling restart tests
  Add support for ignore_unmapped to geo sort (elastic#31153)
jasontedor added a commit that referenced this pull request Jun 8, 2018
* elastic/master: (53 commits)
  Painless: Restructure/Clean Up of Spec Documentation (#31013)
  Update ignore_unmapped serialization after backport
  Add back dropped substitution on merge
  high level REST api: cancel task (#30745)
  Enable engine factory to be pluggable (#31183)
  Remove vestiges of animal sniffer (#31178)
  Rename elasticsearch-nio to nio (#31186)
  Rename elasticsearch-core to core (#31185)
  Move cli sub-project out of server to libs (#31184)
  [DOCS] Fixes broken link in auditing settings
  QA: Better seed nodes for rolling restart
  [DOCS] Moves ML content to stack-docs
  [DOCS] Clarifies recommendation for audit index output type (#31146)
  Add nio-transport as option for http smoke tests (#31162)
  QA: Set better node names on rolling restart tests
  Add support for ignore_unmapped to geo sort (#31153)
  Share common parser in some AcknowledgedResponses (#31169)
  Fix random failure on SearchQueryIT#testTermExpansionExceptionOnSpanFailure
  Remove reference to multiple fields with one name (#31127)
  Remove BlobContainer.move() method (#31100)
  ...
@Tim-Brooks Tim-Brooks deleted the enable_nio_smoke_tests branch December 10, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Network Http and internode communication implementations >non-issue v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants