Docs: Clarify constraints on scripted similarities.#31076
Merged
jpountz merged 2 commits intoelastic:masterfrom Jun 5, 2018
Merged
Docs: Clarify constraints on scripted similarities.#31076jpountz merged 2 commits intoelastic:masterfrom
jpountz merged 2 commits intoelastic:masterfrom
Conversation
Scripted similarities provide a lot of flexibility but they still need to obey some rules to not confuse Lucene.
Collaborator
|
Pinging @elastic/es-search-aggs |
nik9000
approved these changes
Jun 4, 2018
Member
nik9000
left a comment
There was a problem hiding this comment.
I'd be nice if we could enforce this kind of thing. This seems like a good way to really confuse folks. Reminds me of transform a little.
jimczi
approved these changes
Jun 4, 2018
Contributor
jimczi
left a comment
There was a problem hiding this comment.
LGTM
Can we at least ensure that scores are positive in a follow up ?
Contributor
Author
Yeah, do you have ideas how to do it?
Do you mean something like adding assertions to ScriptedSimilarity that scores are positive? |
Member
Not really.... Sorry! It'd be nice but I don't really know. |
martijnvg
added a commit
that referenced
this pull request
Jun 5, 2018
* es/master: Take into account the return value of TcpTransport.readMessageLength(...) in Netty4SizeHeaderFrameDecoder Move caching of the size of a directory to `StoreDirectory`. (#30581) Clarify docs about boolean operator precedence. (#30808) Docs: remove notes on sparsity. (#30905) Fix MatchPhrasePrefixQueryBuilderTests#testPhraseOnFieldWithNoTerms run overflow forecast a 2nd time as regression test for elastic/ml-cpp#110 (#30969) Improve documentation of dynamic mappings. (#30952) Decouple MultiValueMode. (#31075) Docs: Clarify constraints on scripted similarities. (#31076) Update get.asciidoc (#31084)
jpountz
added a commit
that referenced
this pull request
Jun 5, 2018
Scripted similarities provide a lot of flexibility but they still need to obey some rules to not confuse Lucene.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 5, 2018
* elastic/master: [Tests] Muting RatedRequestsTests#testXContentParsingIsNotLenient TEST: Retry synced-flush if ongoing ops on primary (elastic#30978) Fix docs build. Only auto-update license signature if all nodes ready (elastic#30859) Add BlobContainer.writeBlobAtomic() (elastic#30902) Add a doc value format to binary fields. (elastic#30860) Take into account the return value of TcpTransport.readMessageLength(...) in Netty4SizeHeaderFrameDecoder Move caching of the size of a directory to `StoreDirectory`. (elastic#30581) Clarify docs about boolean operator precedence. (elastic#30808) Docs: remove notes on sparsity. (elastic#30905) Fix MatchPhrasePrefixQueryBuilderTests#testPhraseOnFieldWithNoTerms run overflow forecast a 2nd time as regression test for elastic/ml-cpp#110 (elastic#30969) Improve documentation of dynamic mappings. (elastic#30952) Decouple MultiValueMode. (elastic#31075) Docs: Clarify constraints on scripted similarities. (elastic#31076)
dnhatn
added a commit
that referenced
this pull request
Jun 5, 2018
* 6.x: Share common readFrom/writeTo code in AcknowledgeResponse (#30983) [Tests] Muting RatedRequestsTests#testXContentParsingIsNotLenient Fix rest test skip version Fix docs build. Add a doc value format to binary fields. (#30860) Only auto-update license signature if all nodes ready (#30859) Add BlobContainer.writeBlobAtomic() (#30902) Move caching of the size of a directory to `StoreDirectory`. (#30581) Clarify docs about boolean operator precedence. (#30808) Docs: remove notes on sparsity. (#30905) Improve documentation of dynamic mappings. (#30952) Decouple MultiValueMode. (#31075) Docs: Clarify constraints on scripted similarities. (#31076)
Contributor
Yes or even an hard exception to ensure that we don't miss documents if |
Contributor
Author
|
Unfortunately, we'd also miss documents if the function does not honor the constraints on freq and norm. Which is much harder to check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scripted similarities provide a lot of flexibility but they still need to obey
some rules to not confuse Lucene.