remove requirement for shards/replicas in allocation check steps#30855
Merged
talevy merged 1 commit intoelastic:index-lifecyclefrom May 25, 2018
Merged
remove requirement for shards/replicas in allocation check steps#30855talevy merged 1 commit intoelastic:index-lifecyclefrom
talevy merged 1 commit intoelastic:index-lifecyclefrom
Conversation
As we are preparing to support policy updates/changes, we noticed that restricting allocation wait steps with pinned replicas/shard counts makes this difficult to continue from. For example, as user may update or switch a policy to increase replicas. If this is done, then the check will never pass and user intervention will be required. If we simply remove this restriction, we still check that the index is allocated correctly, but without depending on the newly configured replicas setting in the policy.
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
pushed a commit
that referenced
this pull request
Aug 17, 2018
) As we are preparing to support policy updates/changes, we noticed that restricting allocation wait steps with pinned replicas/shard counts makes this difficult to continue from. For example, as user may update or switch a policy to increase replicas. If this is done, then the check will never pass and user intervention will be required. If we simply remove this restriction, we still check that the index is allocated correctly, but without depending on the newly configured replicas setting in the policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are preparing to support policy updates/changes, we noticed
that restricting allocation wait steps with pinned replicas/shard
counts makes this difficult to continue from. For example,
as user may update or switch a policy to increase replicas. If this
is done, then the check will never pass and user intervention will
be required. If we simply remove this restriction, we still check
that the index is allocated correctly, but without depending on
the newly configured replicas setting in the policy.