Conversation
cbuescher
approved these changes
May 24, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
LGTM. I just saw your previous commit (a454bf2) is only on 6.2 so far, are you also going to merge both to the upstream branches?
Also, that commit doesn't have a PR, could you open one even for small changes like this in the future? It makes it easier to track versions and makes it possible to run tests on it. Even minor docs changes have the potential of breaking our build. Thanks.
Collaborator
|
Pinging @elastic/es-distributed |
cbuescher
pushed a commit
that referenced
this pull request
May 25, 2018
cbuescher
pushed a commit
that referenced
this pull request
May 25, 2018
cbuescher
pushed a commit
that referenced
this pull request
May 25, 2018
Contributor
Author
|
Can totally do a PR in future, the first commit I'd done in by accidentally hitting commit instead of PR and facepalmed immediately after I'd done it. |
dnhatn
added a commit
that referenced
this pull request
May 28, 2018
* 6.x: Fix double semicolon in import statement [TEST] Fix minor random bug from #30794 Enabling testing against an external cluster (#30885) SQL: Remove the last remaining server dependencies from jdbc (#30771) Add public key header/footer (#30877) Include size of snapshot in snapshot metadata (#29602) QA: Test template creation during rolling restart (#30850) REST high-level client: add put ingest pipeline API (#30793) Do not serialize basic license exp in x-pack info (#30848) [docs] explainer for java packaging tests (#30825) Verify signatures on official plugins (#30800) [DOCS] Document index name limitations (#30826) [Docs] Add reindex.remote.whitelist example (#30828)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor tweak to fix an example yaml config.