add index.lifecycle.skip setting for skipping policy execution#30766
Merged
talevy merged 5 commits intoelastic:index-lifecyclefrom May 23, 2018
Merged
add index.lifecycle.skip setting for skipping policy execution#30766talevy merged 5 commits intoelastic:index-lifecyclefrom
talevy merged 5 commits intoelastic:index-lifecyclefrom
Conversation
It is useful to pause execution of policies for indices in case the cluster is not in a good place to execute certain actions.
Collaborator
|
Pinging @elastic/es-core-infra |
colings86
approved these changes
May 22, 2018
Contributor
colings86
left a comment
There was a problem hiding this comment.
I left a small comment about log level but otherwise LGTM
| Settings indexSettings = indexMetaData.getSettings(); | ||
| if (LifecycleSettings.LIFECYCLE_SKIP_SETTING.get(indexSettings)) { | ||
| logger.debug("skipping policy [" + policy + "] for index [" + indexMetaData.getIndex().getName() + "]." | ||
| + LifecycleSettings.LIFECYCLE_SKIP + "== true"); |
Contributor
There was a problem hiding this comment.
I think maybe this should be at info level?
jasontedor
pushed a commit
that referenced
this pull request
Aug 17, 2018
It is useful to pause execution of policies for indices in case the cluster is not in a good place to execute certain actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is useful to pause execution of policies for indices in case the cluster
is not in a good place to execute certain actions.
the index update settings api is to be used as an advanced API for configuring this setting on indices that should be paused.