Changes PhaseAfterStep to take the name of the previous phase#30756
Merged
colings86 merged 2 commits intoelastic:index-lifecyclefrom May 24, 2018
colings86:ilm/phaseAfterNaming
Merged
Changes PhaseAfterStep to take the name of the previous phase#30756colings86 merged 2 commits intoelastic:index-lifecyclefrom colings86:ilm/phaseAfterNaming
colings86 merged 2 commits intoelastic:index-lifecyclefrom
colings86:ilm/phaseAfterNaming
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
talevy
reviewed
May 21, 2018
Contributor
There was a problem hiding this comment.
So, for documentation purposes, our phases are now
- new
- hot (optional)
- warm (optional)
- cold (optional)
- delete (optional)
- completed
Contributor
Author
There was a problem hiding this comment.
yes, although we should be clear in the docs that new and completed are not real phases in the fact that you cannot add actions to them
talevy
suggested changes
May 21, 2018
Contributor
talevy
left a comment
There was a problem hiding this comment.
there are some assertions made in rest tests expecting the pre-pre-readonly step
this needs to be updated for tests to pass
Contributor
Author
|
@talevy thanks for pointing that out. I've pushed a fix so hopefully the CI build will pass now |
talevy
approved these changes
May 23, 2018
Contributor
talevy
left a comment
There was a problem hiding this comment.
merging latest index-lifecycle should fix CI on this PR
This changes the way the phase after step is built so its key has the phase name of the phase that preceeds it rather than the phase that follows it. This is more intuitive to the user since the index is in the warm phase until the after condition for the cold phase is met.
x-pack/plugin/src/test/resources/rest-api-spec/test/index_lifecycle/20_m ove_to_step.yml x-pack/plugin/src/test/resources/rest-api-spec/test/index_lifecycle/20_m ove_to_step.yml
jasontedor
pushed a commit
that referenced
this pull request
Aug 17, 2018
* Changes PhaseAfterStep to take the name of the previous phase This changes the way the phase after step is built so its key has the phase name of the phase that preceeds it rather than the phase that follows it. This is more intuitive to the user since the index is in the warm phase until the after condition for the cold phase is met. * Fixes REST tests x-pack/plugin/src/test/resources/rest-api-spec/test/index_lifecycle/20_m ove_to_step.yml x-pack/plugin/src/test/resources/rest-api-spec/test/index_lifecycle/20_m ove_to_step.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the way the phase after step is built so its key has the
phase name of the phase that preceeds it rather than the phase that
follows it. This is more intuitive to the user since the index is in
the warm phase until the after condition for the cold phase is met.