disable annotation processor for docs#30610
Conversation
|
Pinging @elastic/es-core-infra |
Could not find evidence that the log4j annotation processor is used. The compiler flag enables the Gradle 5.0 behavior Closes elastic#30476
nik9000
left a comment
There was a problem hiding this comment.
I wonder if we should apply the build standard build plugin here instead. It brings that along for free.
|
@nik9000 I'm not sure which plugin you mean |
|
@atorok Nik is talking about the BuildPlugin in buildSrc, which is applied to all java projects in elasticsearch. Are you sure this PR fixes the entire project, or only |
|
I would have expected it to pop up for other gradle projects as well, but it only triggered for |
|
Oh I see what is going on now. The build plugin already takes care of this, but it's not applied to docs because it's mutually exclusive with |
| integTest.mustRunAfter(project.precommit) | ||
| project.check.dependsOn(integTest) | ||
|
|
||
| project.tasks.withType(JavaCompile) { |
There was a problem hiding this comment.
I don't think this is actually needed, because StandaloneTestPlugin is required, which also has this. In fact, I think what is here now will cause -proc:none to be in the compile args twice?
| import org.gradle.api.Plugin | ||
| import org.gradle.api.Project | ||
| import org.gradle.api.plugins.JavaBasePlugin | ||
| import org.gradle.api.tasks.compile.JavaCompile |
There was a problem hiding this comment.
Looks like the changes in this file are extraneous and should be reverted
…ne-liners * elastic/master: [TEST] Enable DEBUG logging on testAutoQueueSizingWithMax [ML] Don't install empty ML metadata on startup (elastic#30751) Add assertion on removing copy_settings (elastic#30748) bump lucene version for 6_3_0 [DOCS] Mark painless execute api as experimental (elastic#30710) disable annotation processor for docs (elastic#30610) Add more script contexts (elastic#30721) Fix default shards count in create index docs (elastic#30747)
* master: Reduce CLI scripts to one-liners (#30759) SQL: Preserve scoring in bool queries (#30730) QA: Switch rolling upgrade to 3 nodes (#30728) [TEST] Enable DEBUG logging on testAutoQueueSizingWithMax [ML] Don't install empty ML metadata on startup (#30751) Add assertion on removing copy_settings (#30748) bump lucene version for 6_3_0 [DOCS] Mark painless execute api as experimental (#30710) disable annotation processor for docs (#30610) Add more script contexts (#30721) Fix default shards count in create index docs (#30747) Mute testCorruptFileThenSnapshotAndRestore
* es/ccr: (50 commits) Reduce CLI scripts to one-liners (elastic#30759) SQL: Preserve scoring in bool queries (elastic#30730) QA: Switch rolling upgrade to 3 nodes (elastic#30728) [TEST] Enable DEBUG logging on testAutoQueueSizingWithMax [ML] Don't install empty ML metadata on startup (elastic#30751) Add assertion on removing copy_settings (elastic#30748) bump lucene version for 6_3_0 [DOCS] Mark painless execute api as experimental (elastic#30710) disable annotation processor for docs (elastic#30610) Add more script contexts (elastic#30721) Fix default shards count in create index docs (elastic#30747) Mute testCorruptFileThenSnapshotAndRestore Scripting: Remove getDate methods from ScriptDocValues (elastic#30690) Upgrade to Lucene-7.4.0-snapshot-59f2b7aec2 (elastic#30726) [Docs] Fix single page :docs:check invocation (elastic#30725) Docs: Add uptasticsearch to list of clients (elastic#30738) [DOCS] Removes out-dated x-pack/docs/en/index.asciidoc [DOCS] Removes redundant index.asciidoc files (elastic#30707) [TEST] Reduce forecast overflow to disk test memory limit (elastic#30727) Plugins: Remove meta plugins (elastic#30670) ...
Could not find evidence that the log4j annotation processor is used.
The compiler flag enables the Gradle 5.0 behavior
Closes #30476.