Skip to content

Default ec2 endpoint is ec2.us-east-1.amazonaws.com#30323

Merged
DaveCTurner merged 4 commits intoelastic:masterfrom
dadoonet:doc/27925-fix-default-ec2-endpoint
Dec 14, 2018
Merged

Default ec2 endpoint is ec2.us-east-1.amazonaws.com#30323
DaveCTurner merged 4 commits intoelastic:masterfrom
dadoonet:doc/27925-fix-default-ec2-endpoint

Conversation

@dadoonet
Copy link
Copy Markdown
Contributor

@dadoonet dadoonet commented May 2, 2018

I split #27925 in two parts:

Closes #27464.

@dadoonet
Default ec2 endpoint is ec2.us-east-1.amazonaws.com
9397c61 
I split elastic#27925 in two parts:

* The documentation fix (this PR)
* The code fix (still in elastic#27925)

Closes elastic#27464.
@dadoonet dadoonet added >bug >docs General docs changes :Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure v7.0.0 v6.3.1 labels May 2, 2018
@dadoonet dadoonet self-assigned this May 2, 2018
@dadoonet dadoonet mentioned this pull request May 2, 2018
Closed
@wedneyyuri
Copy link
Copy Markdown

wedneyyuri commented May 2, 2018

Hi @dadoonet, what do you think about changing the statement below?

The only necessary configuration change to enable the plugin is setting the unicast host provider for zen discovery
https://github.com/elastic/elasticsearch/blob/0d11b9fe34c007fddc5cbf2c821ef226b7a0fc75/docs/plugins/discovery-ec2.asciidoc#getting-started-with-aws

@hub-cap hub-cap added :Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure and removed :Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure labels May 3, 2018
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented May 3, 2018

Pinging @elastic/es-distributed

@dadoonet
Copy link
Copy Markdown
Contributor Author

dadoonet commented May 3, 2018

Thanks for the feedback @wedneyyuri! I updated the PR.

@sadok-f
Copy link
Copy Markdown

sadok-f commented Jun 8, 2018

Any update on this PR?

@bleskes
Copy link
Copy Markdown
Contributor

bleskes commented Jun 25, 2018

@TRLX can you see if this can be folded in and close #27464 ?

@davidkyle davidkyle added v6.3.2 and removed v6.3.1 labels Jul 5, 2018
@mdunc
Copy link
Copy Markdown

mdunc commented Aug 6, 2018 •
edited
Loading

Does it normally take this long to fix a documentation bug? I just spent a good chunk of my weekend trying to figure out why my new cluster in EU wasn't working when I had everything configured according to the documentation which incorrectly says the endpoint is auto detected. Wish I found this PR earlier.

@DaveCTurner
Copy link
Copy Markdown
Member

DaveCTurner commented Aug 7, 2018

Unfortunately there was a typo in the earlier ping for a review. It should have notified @tlrx.

@dadoonet
Copy link
Copy Markdown
Contributor Author

dadoonet commented Dec 13, 2018

@elastic/es-distributed Can we merge this documentation PR? People are still suffering from that because our documentation is not accurate. See https://discuss.elastic.co/t/discovery-ec2-plugin-always-tries-to-ping-localhost-never-finds-the-nodes-that-it-should/160433/8

@DaveCTurner DaveCTurner assigned DaveCTurner and unassigned dadoonet Dec 14, 2018
@DaveCTurner DaveCTurner merged commit 5fe4c90 into elastic:master Dec 14, 2018
DaveCTurner pushed a commit that referenced this pull request Dec 14, 2018
@dadoonet @DaveCTurner
Default ec2 endpoint is ec2.us-east-1.amazonaws.com (#30323)
b4f8f20 
Today our docs claim that the `discovery-ec2` plugin auto-detects the EC2
endpoint, but this is not the case. This fixes these docs.

Closes #27464.
DaveCTurner pushed a commit that referenced this pull request Dec 14, 2018
@dadoonet @DaveCTurner
Default ec2 endpoint is ec2.us-east-1.amazonaws.com (#30323)
c37fbca 
Today our docs claim that the `discovery-ec2` plugin auto-detects the EC2
endpoint, but this is not the case. This fixes these docs.

Closes #27464.
@dadoonet dadoonet deleted the doc/27925-fix-default-ec2-endpoint branch December 14, 2018 09:42
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@DaveCTurner DaveCTurner

Labels

>bug :Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure >docs General docs changes v6.5.4 v6.6.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ec2-discovery plugin document is not accurate.

10 participants

@dadoonet @wedneyyuri @elasticmachine @sadok-f @bleskes @mdunc @DaveCTurner @hub-cap @davidkyle @jimczi