Improve docs for disk watermarks#30249
Merged
DaveCTurner merged 2 commits intoelastic:masterfrom Apr 30, 2018
Merged
Conversation
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves elastic#25163
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Apr 30, 2018
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
LGTM (one optional suggestion)
| 85% disk used. It can also be set to an absolute byte value (like `500mb`) | ||
| to prevent Elasticsearch from allocating shards if less than the specified | ||
| amount of space is available. This setting has no effect on brand-new | ||
| shards that have never been allocated before. |
Contributor
There was a problem hiding this comment.
To make this a little bit more explicit, I would add something along the lines of ", for example when a new index is created".
Member
Author
There was a problem hiding this comment.
I changed it to
This setting has no effect on the primary shards of newly-created indices or, specifically, any shards that have never previously been allocated.
WDYT?
DaveCTurner
added a commit
that referenced
this pull request
Apr 30, 2018
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
DaveCTurner
added a commit
that referenced
this pull request
Apr 30, 2018
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
DaveCTurner
added a commit
that referenced
this pull request
Apr 30, 2018
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
DaveCTurner
added a commit
that referenced
this pull request
Apr 30, 2018
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
DaveCTurner
added a commit
that referenced
this pull request
Apr 30, 2018
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 1, 2018
* origin/master: [test] add java packaging test project (elastic#30161) Fix macros in changelog (elastic#30269) [DOCS] Fixes syskeygen command name [ML] Include 3rd party C++ component notices (elastic#30132) _cluster/state Skip Test for pre-6.4, not pre-7.0 (elastic#30264) Improve docs for disk watermarks (elastic#30249) [DOCS] Removes redundant Active Directory realm settings (elastic#30190) [DOCS] Removes redundant LDAP realm settings (elastic#30193) _cluster/state should always return cluster_uuid (elastic#30143) HTML5ify Javadoc for core and test framework (elastic#30234) Minor tweaks to reroute documentation (elastic#30246)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #25163