Reindex: Fold "with all deps" test project into reindex by nik9000 · Pull Request #30154 · elastic/elasticsearch

nik9000 · 2018-04-25T21:23:29Z

This folds the :qa:smoke-test-reindex-with-all-modules project into
:modules:reindex by declaring the reindex's integration testing
cluster requires the parent-join and lang-painless plugins and then
moving all of the integration tests that depended on parent-join and
painless into reindex.

It saves us one cluster start up during the build at the cost of a
little of the reindex module's "purity". Since the reindex module does
have unit tests that test scripting without painless I'm fairly ok with
that.

This folds the `:qa:smoke-test-reindex-with-all-modules` project into `:modules:reindex` by declaring the reindex's integration testing cluster requires the `parent-join` and `lang-painless` plugins and then moving all of the integration tests that depended on parent-join and painless into reindex. It saves us one cluster start up during the build at the cost of a little of the reindex module's "purity". Since the reindex module *does* have unit tests that test scripting without painless I'm fairly ok with that.

nik9000 · 2018-04-25T21:24:12Z

...ke-test-reindex-with-all-modules/src/test/resources/rest-api-spec/test/reindex/20_broken.yml

-          script:
-            lang: painless
-            source: syntax errors are fun!
-  - match: {error.reason: 'compile error'}


I moved this into the scripting file.

nik9000 · 2018-04-25T21:24:31Z

...e-test-reindex-with-all-modules/src/test/resources/rest-api-spec/test/reindex/30_timeout.yml

-"Timeout":
-  - skip:
-      version: "all"
-      reason:  painless doesn't support thread.sleep so we need to come up with a better way


We haven't been running this for forever and we've been ok so I just dropped it.

nik9000 · 2018-04-25T21:24:39Z

...reindex-with-all-modules/src/test/resources/rest-api-spec/test/update_by_query/20_broken.yml

@@ -1,21 +0,0 @@
---
-"Totally broken scripts report the error properly":


I moved this into the scripting file.

nik9000 · 2018-04-25T21:24:54Z

...eindex-with-all-modules/src/test/resources/rest-api-spec/test/update_by_query/30_timeout.yml

@@ -1,30 +0,0 @@
---
-"Timeout":


We haven't been running this in forever so I just dropped it.

elasticmachine · 2018-04-26T12:38:24Z

Pinging @elastic/es-distributed

nik9000 · 2018-04-26T18:17:32Z

The build failure was a timeout waiting for x-pack.

@elasticmachine, retest this please.

nik9000 · 2018-04-26T22:57:35Z

Sigh. @elasticmachine, retest this please

jasontedor

LGTM. We might revisit this depending on if we come to a conclusion about integ-test-zip.

nik9000 · 2018-05-10T12:05:55Z

LGTM. We might revisit this depending on if we come to a conclusion about integ-test-zip.

Thanks! I agree. We might switch around the gradle bit a bit if we make a decision on integ-test-zip but I think this is a step in the right direction in the mean time.

I've merge and am backporting now.

This folds the `:qa:smoke-test-reindex-with-all-modules` project into `:modules:reindex` by declaring the reindex's integration testing cluster requires the `parent-join` and `lang-painless` plugins and then moving all of the integration tests that depended on parent-join and painless into reindex. It saves us one cluster start up during the build at the cost of a little of the reindex module's "purity". Since the reindex module *does* have unit tests that test scripting without painless I'm fairly ok with that.

* master: Upgrade to Lucene-7.4-snapshot-6705632810 (#30519) add version compatibility from 6.4.0 after backport, see #30319 (#30390) Security: Simplify security index listeners (#30466) Add proper longitude validation in geo_polygon_query (#30497) Remove Discovery.AckListener.onTimeout() (#30514) Build: move generated-resources to build (#30366) Reindex: Fold "with all deps" project into reindex (#30154) Isolate REST client single host tests (#30504) Solve Gradle deprecation warnings around shadowJar (#30483) SAML: Process only signed data (#30420) Remove BWC repository test (#30500) Build: Remove xpack specific run task (#30487) AwaitsFix IntegTestZipClientYamlTestSuiteIT#indices.split tests LLClient: Add setJsonEntity (#30447) Expose CommonStatsFlags directly in IndicesStatsRequest. (#30163) Silence IndexUpgradeIT test failures. (#30430) Bump Gradle heap to 1792m (#30484) [docs] add warning for read-write indices in force merge documentation (#28869) Avoid deadlocks in cache (#30461) Test: remove hardcoded list of unconfigured ciphers (#30367) mute SplitIndexIT due to #30416 Docs: Test examples that recreate lang analyzers (#29535) BulkProcessor to retry based on status code (#29329) Add GET Repository High Level REST API (#30362) add a comment explaining the need for RetryOnReplicaException on missing mappings Add `coordinating_only` node selector (#30313) Stop forking groovyc (#30471) Avoid setting connection request timeout (#30384) Use date format in `date_range` mapping before fallback to default (#29310) Watcher: Increase HttpClient parallel sent requests (#30130) # Conflicts: # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/LocalStateCompositeXPackPlugin.java

* 6.x: Upgrade to Lucene-7.4-snapshot-6705632810 (#30519) Remove Discovery.AckListener.onTimeout() (#30514) Build: move generated-resources to build (#30366) Reindex: Fold "with all deps" project into reindex (#30154) Isolate REST client single host tests (#30504) Remove BWC repository test (#30500) Build: Remove xpack specific run task (#30487) AwaitsFix IntegTestZipClientYamlTestSuiteIT#indices.split tests LLClient: Add setJsonEntity (#30447) [docs] add warning for read-write indices in force merge documentation (#28869) Avoid deadlocks in cache (#30461) BulkProcessor to retry based on status code (#29329) Avoid setting connection request timeout (#30384) Test: remove hardcoded list of unconfigured ciphers (#30367) Add GET Repository High Level REST API (#30362) mute SplitIndexIT due to #30416 Docs: Test examples that recreate lang analyzers (#29535) add a comment explaining the need for RetryOnReplicaException on missing mappings Pass the task to broadcast actions (#29672) Stop forking groovyc (#30471) Add `coordinating_only` node selector (#30313) Fix accidental error in changelog Use date format in `date_range` mapping before fallback to default (#29310) Watcher: Increase HttpClient parallel sent requests (#30130) [Security][Tests] Azeri(Turkish) locale tripps opensaml dependency

* es/ccr: (78 commits) Upgrade to Lucene-7.4-snapshot-6705632810 (elastic#30519) add version compatibility from 6.4.0 after backport, see elastic#30319 (elastic#30390) Security: Simplify security index listeners (elastic#30466) Add proper longitude validation in geo_polygon_query (elastic#30497) Remove Discovery.AckListener.onTimeout() (elastic#30514) Build: move generated-resources to build (elastic#30366) Reindex: Fold "with all deps" project into reindex (elastic#30154) Isolate REST client single host tests (elastic#30504) Solve Gradle deprecation warnings around shadowJar (elastic#30483) SAML: Process only signed data (elastic#30420) Remove BWC repository test (elastic#30500) Build: Remove xpack specific run task (elastic#30487) AwaitsFix IntegTestZipClientYamlTestSuiteIT#indices.split tests Enable soft-deletes in v6.4 LLClient: Add setJsonEntity (elastic#30447) [CCR] Read changes from Lucene instead of translog (elastic#30120) Expose CommonStatsFlags directly in IndicesStatsRequest. (elastic#30163) Silence IndexUpgradeIT test failures. (elastic#30430) Bump Gradle heap to 1792m (elastic#30484) [docs] add warning for read-write indices in force merge documentation (elastic#28869) ...

nik9000 added >non-issue review :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v7.0.0 v6.4.0 labels Apr 25, 2018

nik9000 commented Apr 25, 2018

View reviewed changes

hub-cap added :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. and removed :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels Apr 26, 2018

Merge branch 'master' into reindex_with_deps

4abb450

nik9000 added 3 commits April 27, 2018 14:19

Merge branch 'master' into reindex_with_deps

e04cd1e

Merge branch 'master' into reindt push nik9000ex_with_deps

1226c9d

Merge branch 'master' into reindex_with_deps

7d12233

jasontedor approved these changes May 9, 2018

View reviewed changes

nik9000 merged commit 51fa873 into elastic:master May 10, 2018

colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reindex: Fold "with all deps" test project into reindex#30154

Reindex: Fold "with all deps" test project into reindex#30154
nik9000 merged 5 commits intoelastic:masterfrom
nik9000:reindex_with_deps

nik9000 commented Apr 25, 2018

Uh oh!

nik9000 Apr 25, 2018

Uh oh!

nik9000 Apr 25, 2018

Uh oh!

nik9000 Apr 25, 2018

Uh oh!

nik9000 Apr 25, 2018

Uh oh!

elasticmachine commented Apr 26, 2018

Uh oh!

nik9000 commented Apr 26, 2018

Uh oh!

nik9000 commented Apr 26, 2018

Uh oh!

jasontedor left a comment

Uh oh!

nik9000 commented May 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -1,21 +0,0 @@
		---
		"Totally broken scripts report the error properly":

Conversation

nik9000 commented Apr 25, 2018

Uh oh!

nik9000 Apr 25, 2018

Choose a reason for hiding this comment

Uh oh!

nik9000 Apr 25, 2018

Choose a reason for hiding this comment

Uh oh!

nik9000 Apr 25, 2018

Choose a reason for hiding this comment

Uh oh!

nik9000 Apr 25, 2018

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 26, 2018

Uh oh!

nik9000 commented Apr 26, 2018

Uh oh!

nik9000 commented Apr 26, 2018

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

nik9000 commented May 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants