Plugins: Fix module name conflict check for meta plugins#29146
Merged
rjernst merged 2 commits intoelastic:masterfrom Mar 20, 2018
Merged
Plugins: Fix module name conflict check for meta plugins#29146rjernst merged 2 commits intoelastic:masterfrom
rjernst merged 2 commits intoelastic:masterfrom
Conversation
This commit moves the check for plugin names conflicting with builtin modules to a location that also applies to meta plugins.
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
requested changes
Mar 19, 2018
Member
jasontedor
left a comment
There was a problem hiding this comment.
I spotted something that needs correcting.
|
|
||
| // checking for existing version of the plugin | ||
| private void verifyPluginName(Path pluginPath, String pluginName, Path candidateDir) throws UserException, IOException { | ||
| // don't let luser install plugin conflicting with module... |
Member
Author
There was a problem hiding this comment.
I'm not going to argue (I pushed 49977e9), but I think it was fine how it (originally) was.
hub-cap
approved these changes
Mar 20, 2018
Contributor
hub-cap
left a comment
There was a problem hiding this comment.
LGTM, verified jasons comment was addressed
Member
Author
|
Thanks @jasontedor and @hub-cap |
rjernst
added a commit
that referenced
this pull request
Mar 20, 2018
This commit moves the check for plugin names conflicting with builtin modules to a location that also applies to meta plugins.
martijnvg
added a commit
that referenced
this pull request
Mar 21, 2018
* es/master: (50 commits) Reject updates to the `_default_` mapping. (#29165) Improve similarity docs. (#29089) [Docs] Update api.asciidoc (#29166) Docs: Add note about missing mapping for doc values field (#29036) Fix BWC issue for PreSyncedFlushResponse Remove BytesArray and BytesReference usage from XContentFactory (#29151) Add pluggable XContentBuilder writers and human readable writers (#29120) Add unreleased version 6.2.4 (#29171) Add unreleased version 6.1.5 (#29168) Add a note about using the `retry_failed` flag before accepting data loss (#29160) Fix typo in percolate-query.asciidoc (#29155) Require HTTP::Tiny 0.070 for release notes script Set Java 9 checkstyle to depend on checkstyle conf (#28383) REST high-level client: add clear cache API (#28866) Docs: Add example of resetting index setting (#29048) Plugins: Fix module name conflict check for meta plugins (#29146) Build: Fix meta plugin bundled plugin names (#29147) Build: Simplify rest spec hack configuration (#29149) Build: Fix meta modules to not install as plugin in tests (#29150) Fix javadoc warning in Strings for missing parameter description ...
martijnvg
added a commit
that referenced
this pull request
Mar 21, 2018
* es/6.x: (46 commits) Docs: Add note about missing mapping for doc values field (#29036) [DOCS] Removed 6.1.4, 6.2.2, and 6.2.3 coming tags Remove BytesArray and BytesReference usage from XContentFactory (#29151) Fix BWC issue for PreSyncedFlushResponse Add pluggable XContentBuilder writers and human readable writers (#29120) Add unreleased version 6.2.4 (#29171) Add unreleased version 6.1.5 (#29168) Add a note about using the `retry_failed` flag before accepting data loss (#29160) Fix typo in percolate-query.asciidoc (#29155) Add release notes for 6.1.4 and 6.2.3 Require HTTP::Tiny 0.070 for release notes script REST high-level client: add clear cache API (#28866) Relax remote check for bwc project checkouts (#28666) Set Java 9 checkstyle to depend on checkstyle conf (#28383) Docs: Add example of resetting index setting (#29048) Plugins: Fix module name conflict check for meta plugins (#29146) Build: Fix meta plugin bundled plugin names (#29147) Build: Simplify rest spec hack configuration (#29149) CLI: Close subcommands in MultiCommand (#28954) Build: Fix meta modules to not install as plugin in tests (#29150) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the check for plugin names conflicting with builtin
modules to a location that also applies to meta plugins.