Use EnumMap in ClusterBlocks#29112
Merged
cbuescher merged 1 commit intoelastic:masterfrom Mar 22, 2018
Merged
Conversation
By using EnumMap instead of an ImmutableLevelHolder array we can avoid the using enum ordinals to index into the array as this might potentially break.
jpountz
approved these changes
Mar 16, 2018
Contributor
jpountz
left a comment
There was a problem hiding this comment.
I like the change from a readability perspective but I don't understand why indexing using might break at some point? As far as I know this is what EnumMap does internally.
Member
Author
You are right, I was thinking about changes in the enum order but that wouldn't break inside a single JVM, and this doesn't prevent breaking on serialization where we also use the enum ordinals. Are you still okay merging this for readability reasons? |
cbuescher
pushed a commit
that referenced
this pull request
Mar 22, 2018
By using EnumMap instead of an ImmutableLevelHolder array we can avoid the using enum ordinals to index into the array.
martijnvg
added a commit
that referenced
this pull request
Mar 26, 2018
* es/master: (27 commits) [Docs] Add rank_eval size parameter k (#29218) [DOCS] Remove ignore_z_value parameter link Docs: Update docs/index_.asciidoc (#29172) Docs: Link C++ client lib elasticlient (#28949) [DOCS] Unregister repository instead of deleting it (#29206) Docs: HighLevelRestClient#multiSearch (#29144) Add Z value support to geo_shape Remove type casts in logging in server component (#28807) Change BroadcastResponse from ToXContentFragment to ToXContentObject (#28878) REST : Split `RestUpgradeAction` into two actions (#29124) Add error file docs to important settings Add note to low-level client docs for DNS caching (#29213) Harden periodically check to avoid endless flush loop (#29125) Remove deprecated options for query_string (#29203) REST high-level client: add force merge API (#28896) Remove license information from README.textile (#29198) Decouple more classes from XContentBuilder and make builder strict (#29197) [Docs] Fix missing closing block in cluster/misc.asciidoc RankEvalRequest should implement IndicesRequest (#29188) Use EnumMap in ClusterBlocks (#29112) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor change. By using EnumMap instead of the ImmutableLevelHolder array
we can avoid using ClusterBlockLevel enum ordinals to index into the array, which
might potentially break at some point.