Fixing URL to Grok patterns#29088
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Nit: a slight improvement would be to link to the grok-patterns file on the current branch (either master or one of the version branches, e.g. 6.x, 6.2). You can use the {branch} placeholder for this inside the link as I just learned recently
There was a problem hiding this comment.
Thanks for your suggestion. It's fixed now.
54c90ce to
5bce41a
Compare
There was a problem hiding this comment.
Sorry about nitpicking, but when I re-checked the target directory for the link, I saw that maybe the parent directory (https://github.com/elastic/elasticsearch/tree/master/libs/grok/src/main/resources/patterns) would be a better choice? I think the link originally pointed there (e.g. on 5.6 branch: https://github.com/elastic/elasticsearch/tree/5.6/modules/ingest-common/src/main/resources/patterns)
Maybe @mvg would also know if the number of patterns should be adapted while we are at it. Looks like way more thank 120 to me, are they all packaged with the grok processor or only a subset of them?
There was a problem hiding this comment.
You are right. The link should point into the directory and not to the file. I have fixed that and I have also changed the wording a little bit to be more future-proof.
5bce41a to
a04906f
Compare
cbuescher
left a comment
There was a problem hiding this comment.
Thanks, LGTM
Will run final tests before merging.
|
@elasticmachine test this please |
* es/6.x: (89 commits) Clarify requirements of strict date formats. (#29090) Clarify that dates are always rendered as strings. (#29093) [Docs] Fix link to Grok patterns (#29088) Fix starting on Windows from another drive (#29086) Use removeTask instead of finishTask in PersistentTasksClusterService (#29055) Added minimal docs for reindex api in java-api docs Allow overriding JVM options in Windows service (#29044) Clarify how to set compiler and runtime JDKs (#29101) Fix Parsing Bug with Update By Query for Stored Scripts (#29039) TEST: write ops should execute under shard permit (#28966) [DOCS] Add X-Pack upgrade details (#29038) Revert "Improve error message for installing plugin (#28298)" Docs: HighLevelRestClient#exists (#29073) Validate regular expressions in dynamic templates. (#29013) [Tests] Fix GetResultTests and DocumentFieldTests failures (#29083) Reenable LiveVersionMapTests.testRamBytesUsed on Java 9. (#29063) Mute failing GetResultTests and DocumentFieldTests [Docs] Fix Java Api index administration usage (#28260) Improve error message for installing plugin (#28298) Decouple XContentBuilder from BytesReference (#28972) ...
* es/master: (97 commits) Clarify requirements of strict date formats. (#29090) Clarify that dates are always rendered as strings. (#29093) Compilation fix for #29067 [Docs] Fix link to Grok patterns (#29088) Store offsets in index prefix fields when stored in the parent field (#29067) Fix starting on Windows from another drive (#29086) Use removeTask instead of finishTask in PersistentTasksClusterService (#29055) Added minimal docs for reindex api in java-api docs Allow overriding JVM options in Windows service (#29044) Clarify how to set compiler and runtime JDKs (#29101) CLI: Close subcommands in MultiCommand (#28954) TEST: write ops should execute under shard permit (#28966) [DOCS] Add X-Pack upgrade details (#29038) Revert "Improve error message for installing plugin (#28298)" Docs: HighLevelRestClient#exists (#29073) Validate regular expressions in dynamic templates. (#29013) [Tests] Fix GetResultTests and DocumentFieldTests failures (#29083) Reenable LiveVersionMapTests.testRamBytesUsed on Java 9. (#29063) Mute failing GetResultTests and DocumentFieldTests Improve error message for installing plugin (#28298) ...
This PR is just fixing the link to the Grok reusable patterns.