Add ingest-attachment support for per document indexed_chars limit#28977
Merged
dadoonet merged 4 commits intoelastic:masterfrom Mar 14, 2018
Merged
Add ingest-attachment support for per document indexed_chars limit#28977dadoonet merged 4 commits intoelastic:masterfrom
indexed_chars limit#28977dadoonet merged 4 commits intoelastic:masterfrom
Conversation
We today support a global `indexed_chars` processor parameter. But in some cases, users would like to set this limit depending on the document itself.
It used to be supported in mapper-attachments plugin by extracting the limit value from a meta field in the document sent to indexation process.
We add an option which reads this limit value from the document itself
by adding a setting named `indexed_chars_field`.
Which allows running:
```
PUT _ingest/pipeline/attachment
{
"description" : "Extract attachment information. Used to parse pdf and office files",
"processors" : [
{
"attachment" : {
"field" : "data",
"indexed_chars_field" : "size"
}
}
]
}
```
Then index either:
```
PUT index/doc/1?pipeline=attachment
{
"data": "BASE64"
}
```
Which will use the default value (or the one defined by `indexed_chars`)
Or
```
PUT index/doc/2?pipeline=attachment
{
"data": "BASE64",
"size": 1000
}
```
Closes elastic#28942
Collaborator
|
Pinging @elastic/es-core-infra |
martijnvg
approved these changes
Mar 12, 2018
| "data": "e1xydGYxXGFuc2kNCkxvcmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0DQpccGFyIH0=", | ||
| "attachment": { | ||
| "content_type": "application/rtf", | ||
| "language": "ro", |
Member
There was a problem hiding this comment.
The doc build fails, because sl is returned instead.
Contributor
Author
There was a problem hiding this comment.
True. TBH I was expecting that as I did not run the doc check myself but let the CI do it (I was in a taxi when I pushed my PR ;) )...
I'll fix it, run a check locally and let the CI say ok.
Thanks!
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@martijnvg Apparently CI is still unhappy but I'm unsure if it's my fault. Could you check it please? |
Member
|
@dadoonet The test failure looks unrelated to this change. Maybe rebase master and re-run the pr build? |
Contributor
Author
|
Hmmm. Sounds like I forgot to backport this PR in 6.3 branch. |
Member
Yes, that makes sense to me. |
dadoonet
added a commit
that referenced
this pull request
Jun 15, 2018
We today support a global `indexed_chars` processor parameter. But in some cases, users would like to set this limit depending on the document itself.
It used to be supported in mapper-attachments plugin by extracting the limit value from a meta field in the document sent to indexation process.
We add an option which reads this limit value from the document itself
by adding a setting named `indexed_chars_field`.
Which allows running:
```
PUT _ingest/pipeline/attachment
{
"description" : "Extract attachment information. Used to parse pdf and office files",
"processors" : [
{
"attachment" : {
"field" : "data",
"indexed_chars_field" : "size"
}
}
]
}
```
Then index either:
```
PUT index/doc/1?pipeline=attachment
{
"data": "BASE64"
}
```
Which will use the default value (or the one defined by `indexed_chars`)
Or
```
PUT index/doc/2?pipeline=attachment
{
"data": "BASE64",
"size": 1000
}
```
Backport of #28977 in 6.x branch (6.4.0)
dadoonet
added a commit
that referenced
this pull request
Jun 16, 2018
…31352) We today support a global `indexed_chars` processor parameter. But in some cases, users would like to set this limit depending on the document itself. It used to be supported in mapper-attachments plugin by extracting the limit value from a meta field in the document sent to indexation process. We add an option which reads this limit value from the document itself by adding a setting named `indexed_chars_field`. Which allows running: ``` PUT _ingest/pipeline/attachment { "description" : "Extract attachment information. Used to parse pdf and office files", "processors" : [ { "attachment" : { "field" : "data", "indexed_chars_field" : "size" } } ] } ``` Then index either: ``` PUT index/doc/1?pipeline=attachment { "data": "BASE64" } ``` Which will use the default value (or the one defined by `indexed_chars`) Or ``` PUT index/doc/2?pipeline=attachment { "data": "BASE64", "size": 1000 } ``` Backport of #28977 in 6.x branch (6.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We today support a global
indexed_charsprocessor parameter. But in some cases, users would like to set this limit depending on the document itself.It used to be supported in mapper-attachments plugin by extracting the limit value from a meta field in the document sent to indexation process.
We add an option which reads this limit value from the document itself
by adding a setting named
indexed_chars_field.Which allows running:
Then index either:
Which will use the default value (or the one defined by
indexed_chars)Or
Closes #28942.